Page MenuHomeFreeBSD

nvme: Allow command opcodes with lower bit clear as reads
Needs ReviewPublic

Authored by imp on Tue, Apr 29, 5:15 AM.

Details

Reviewers
chuck
chs
mav
Summary

Linux does this, and nvme-cli has some vendor specific opcodes that need
this.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63770
Build 60654: arc lint + arc unit

Event Timeline

imp requested review of this revision.Tue, Apr 29, 5:15 AM
sys/dev/nvme/nvme_ctrlr.c
1371

So now when the OP code's data transfer field says there is no data and this is a "user command" (all the instances of nvme_ctrlr_linux_passthru_cmd() appear to set this to true), the driver is going to allocate npc->data_len worth of memory? Any concerns about the value of data_len potentially being set for a command that wouldn't normally transfer data?