Differential D50004

LinuxKPI: define time64_t
ClosedPublic
Actions

Authored by bz on Thu, Apr 24, 2:20 PM.

Tags

None

Referenced Files

	F115675686: D50004.id154222.diff
	Sat, Apr 26, 11:28 PM

	Unknown Object (File)
	Sat, Apr 26, 1:12 PM

	Unknown Object (File)
	Sat, Apr 26, 11:09 AM

	Unknown Object (File)
	Sat, Apr 26, 8:25 AM

	Unknown Object (File)
	Fri, Apr 25, 6:06 AM

	Unknown Object (File)
	Fri, Apr 25, 6:01 AM

	Unknown Object (File)
	Fri, Apr 25, 5:35 AM

	Unknown Object (File)
	Fri, Apr 25, 4:04 AM

Subscribers

Details

Reviewers

markj
imp
emaste

Group Reviewers

Commits

rG8b51cd07f69e: LinuxKPI: define time64_t

Summary

Define time64_t to time_t apart from i386 where we define it to int64_t
given the native implementation still is int32_t.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 63706
Build 60590: arc lint + arc unit

Event Timeline

bz created this revision.Thu, Apr 24, 2:20 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptThu, Apr 24, 2:20 PM

bz requested review of this revision.Thu, Apr 24, 2:20 PM

Harbormaster completed remote builds in B63706: Diff 154222.Thu, Apr 24, 2:20 PM

bz added a child revision: D50007: LinuxKPI: sysfs: implement sysfs_match_string().Thu, Apr 24, 2:24 PM

emaste added a reviewer: markj.Thu, Apr 24, 3:10 PM

In Linux this is defined in time64.h, but here is fine for now I guess.

This revision is now accepted and ready to land.Thu, Apr 24, 4:39 PM

imp added inline comments.Thu, Apr 24, 5:19 PM

sys/compat/linuxkpi/common/include/linux/time.h
49	why not just typedef int64_t time64_t; and be done with it?

So I don't think the ifdef is needed or desirable. Linux wants time64_t to be exactly a int64_t, so we should do that.

bz added inline comments.Thu, Apr 24, 6:48 PM

sys/compat/linuxkpi/common/include/linux/time.h
49	I guess people know what the native time_t is (on i386) and can deal with it that it may never be a 64bit value. Or otherwise we hope i386 is gone by then -- at least from LinuxKPI. It's likely only time_uptime? I mostly did this as documentation to point out that there is a discrepancy. I am fine either way and I'll happily update it if that's the consensus.

So I'm good either way, I just don't like #ifdefs, especially ones that are 'logical' only and not really needed.
But I've said my piece, and will move along.

sys/compat/linuxkpi/common/include/linux/time.h
49	I'd be tempted to use the i386 line as it is now, and only that line :) There's also an ambiguity in time_t. It's both an absolute time and a relative time (well, really, the absolute time is just a relative time to 1970). Uptime is a relative time with an epoch of when the computer was last booted. So for things like time_uptime, it will be completely adequate. The longest known Unix uptime is still much less than 66 years, and i386 lunuxkpi users are going to encounter several other issues well before that runs out, even if they booted today and depended on linux_uptime....

plainly typedef time64_t to int64_t as suggested by @imp.

This revision now requires review to proceed.Thu, Apr 24, 10:11 PM

Harbormaster completed remote builds in B63713: Diff 154243.Thu, Apr 24, 10:11 PM

@markj @imp are you fine with this as-is now?

imp accepted this revision.Sat, Apr 26, 6:46 PM

This revision is now accepted and ready to land.Sat, Apr 26, 6:46 PM

emaste accepted this revision as: emaste.Sun, Apr 27, 12:04 AM

markj accepted this revision.Sun, Apr 27, 1:45 PM

Closed by commit rG8b51cd07f69e: LinuxKPI: define time64_t (authored by bz). · Explain WhySun, Apr 27, 8:33 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG8b51cd07f69e: LinuxKPI: define time64_t.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

6 lines

Diff 154222

sys/compat/linuxkpi/common/include/linux/time.h

Loading...