Page MenuHomeFreeBSD

iwx: Try to make error messages cleared
AcceptedPublic

Authored by thj on Mon, Apr 14, 1:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 11:56 AM
Unknown Object (File)
Sun, Apr 20, 12:53 AM
Unknown Object (File)
Fri, Apr 18, 12:46 PM
Unknown Object (File)
Thu, Apr 17, 6:55 AM
Unknown Object (File)
Thu, Apr 17, 2:45 AM
Unknown Object (File)
Thu, Apr 17, 2:10 AM
Unknown Object (File)
Wed, Apr 16, 2:11 PM
Unknown Object (File)
Wed, Apr 16, 11:45 AM

Details

Reviewers
adrian
bz
Group Reviewers
wireless
Summary

There are quite a lot of prints in the firmware error path right of iwx.
Try and make it clearer where the errors are coming from particularly
make it clear that transferring firmware failed, not loading firmware.

High the init firmware failed message behind a debug level, there are
other errors which will show already in this path and for most people
this doesn't add much.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 63502
Build 60386: arc lint + arc unit

Event Timeline

thj requested review of this revision.Mon, Apr 14, 1:47 PM

I like this!

We also likely can create an IWN_PRINTF(sc, fmt, ...) that does device_printf(), so you're not manually assembling things with DEVNAME, etc.
Let's talk about it on irc. :-)

This revision is now accepted and ready to land.Mon, Apr 14, 2:19 PM