cdefs.h is included for __packed; just assume that types.h includes
cdefs.h as that's a very common assumption.
PR: 285924
Differential D49735
netinet: Make ip.h self-contained markj on Wed, Apr 9, 1:41 PM. Authored by Tags None Referenced Files
Details cdefs.h is included for __packed; just assume that types.h includes PR: 285924
Diff Detail
Event TimelineComment Actions IMO the commit message could use one more sentence introducing the justification (which was reasonably explained in either the PR or the upstream report IIRC) but LGTM. Comment Actions Also we have some commentary in style(9) about kernel headers visible to userland applications: In header files visible to userland applications, prototypes that are visible must use either “protected” names (ones beginning with an underscore) or no names with the types. It is preferable to use protected names. E.g., use: We ought to make a note of our (evolving) approach wrt self-contained headers there. I can pick that up if nobody else wants to. |