mkimg: Add a reproducible mode
Needs ReviewPublic
Actions

Authored by markj on Tue, Apr 8, 9:49 PM.

Details

Reviewers

emaste
bnovkov

Summary

Merge the FreeBSD-specific implementation of osdep_uuidgen() with that
of Linux. While the latter is more complex, it lets us ensure that the
returned UUIDs are reproducible.

This mainly affects the UUID embedded in the GPT header.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63393
Build 60277: arc lint + arc unit

Event Timeline

markj created this revision.Tue, Apr 8, 9:49 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptTue, Apr 8, 9:49 PM

markj requested review of this revision.Tue, Apr 8, 9:49 PM

Harbormaster completed remote builds in B63393: Diff 153368.Tue, Apr 8, 9:49 PM

emaste added inline comments.Tue, Apr 8, 9:54 PM

usr.bin/mkimg/uuid.c
62	We could (also) check `SOURCE_DATE_EPOCH` here

markj added inline comments.Tue, Apr 8, 9:58 PM

usr.bin/mkimg/uuid.c
62	There are random(3) calls below, which is why I didn't do that here, but mkimg wasn't seeding the PRNG so I believe they are effectively deterministic anyway (modulo random(3) implementation being the same).