Add the CPU identification string to the data which is visible in the bootloader.
ClosedPublic
Actions

Authored by rpokala on Tue, Apr 8, 6:09 AM.

Details

Reviewers

manu
imp

Commits

rGb337e9fd1171: loader: Add the CPU identification string to the data which is visible
rG3adae4f27d60: loader: Add the CPU identification string to the data which is visible

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 63384
Build 60268: arc lint + arc unit

Event Timeline

rpokala created this revision.Tue, Apr 8, 6:09 AM

Herald added a reviewer: manu. · View Herald TranscriptTue, Apr 8, 6:09 AM

Herald added subscribers: dab, imp. · View Herald Transcript

rpokala requested review of this revision.Tue, Apr 8, 6:09 AM

Harbormaster completed remote builds in B63384: Diff 153297.Tue, Apr 8, 6:09 AM

rpokala retitled this revision from Add the CPU identification string to the data which is visible in the bootloader. MFC after: 1 week Sponsored by: Vdura to Add the CPU identification string to the data which is visible in the bootloader..Tue, Apr 8, 6:10 AM

rpokala added a reviewer: imp.

imp accepted this revision.Tue, Apr 8, 8:36 AM

This revision is now accepted and ready to land.Tue, Apr 8, 8:36 AM

So what is version? A number or a description? Thinking about it after I click approve i waz suddenly unsure about this detail

This revision now requires changes to proceed.Tue, Apr 8, 8:39 AM

In D49708#1133390, @imp wrote:

So what is version? A number or a description? Thinking about it after I click approve i waz suddenly unsure about this detail

It's the identification string embedded in the CPUID, which is reported in DMI section 4:

[threepio:~] rpokala% sudo dmidecode -t 4 | grep Version
	Version: AMD Ryzen 9 7900 12-Core Processor             
[threepio:~] rpokala% kenv smbios.processor.version
AMD Ryzen 9 7900 12-Core Processor             
[threepio:~] rpokala% kenv | grep smbios.processor.version
smbios.processor.version="AMD Ryzen 9 7900 12-Core Processor             "
[threepio:~] rpokala% /usr/local/bin/cpuid | grep -E '^(8000000[234]|Vendor ID|Processor name string)'
80000002 20444d41 657a7952 2039206e 30303937
80000003 2d323120 65726f43 6f725020 73736563
80000004 2020726f 20202020 20202020 00202020
Vendor ID: "AuthenticAMD"; CPUID level 16
Processor name string: AMD Ryzen 9 7900 12-Core Processor             
[threepio:~] rpokala%

@imp: ping? I answered your question.

imp accepted this revision.Fri, Apr 11, 2:43 AM

This revision is now accepted and ready to land.Fri, Apr 11, 2:43 AM

Closed by commit rG3adae4f27d60: loader: Add the CPU identification string to the data which is visible (authored by rpokala). · Explain WhyFri, Apr 11, 4:05 AM

This revision was automatically updated to reflect the committed changes.

rpokala added a commit: rG3adae4f27d60: loader: Add the CPU identification string to the data which is visible.

rpokala added a commit: rGb337e9fd1171: loader: Add the CPU identification string to the data which is visible.Sun, Apr 20, 7:03 AM