ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser
ClosedPublic
Actions

Authored by jhb on Wed, Apr 2, 8:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 20, 11:59 AM

	Unknown Object (File)
	Fri, Apr 18, 8:45 AM

	Unknown Object (File)
	Tue, Apr 15, 6:01 AM

	Unknown Object (File)
	Tue, Apr 15, 12:55 AM

	Unknown Object (File)
	Mon, Apr 14, 12:23 AM

	Unknown Object (File)
	Fri, Apr 11, 4:43 PM

	Unknown Object (File)
	Fri, Apr 11, 5:01 AM

	Unknown Object (File)
	Mon, Apr 7, 5:44 AM

View All 11 Files

Subscribers

imp

Details

Reviewers

asomers

Commits

rGbf4115671292: ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser

Summary

The code was checking the non-mutual UCL objects twice instead.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63290
Build 60174: arc lint + arc unit

Event Timeline

jhb created this revision.Wed, Apr 2, 8:05 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Apr 2, 8:05 PM

jhb requested review of this revision.Wed, Apr 2, 8:05 PM

Harbormaster completed remote builds in B63290: Diff 153044.Wed, Apr 2, 8:05 PM

jhb added a parent revision: D49644: ctld: Remove dead code in UCL parsing of hex DSCP values.Wed, Apr 2, 8:05 PM

jhb added a child revision: D49646: ctld: Drop commented-out code to print the configuration.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Apr 11, 2:04 PM

Closed by commit rGbf4115671292: ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGbf4115671292: ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

uclparse.cc

8 lines

Diff 153044

View Options

ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parserClosedPublicActions