Page MenuHomeFreeBSD

makefs: Remove redundant 'stampst' checks in several backends
AcceptedPublic

Authored by bnovkov on Tue, Apr 1, 11:44 AM.
Tags
None
Referenced Files
F115941140: D49601.diff
Wed, Apr 30, 4:38 PM
F115871415: D49601.diff
Tue, Apr 29, 8:10 PM
Unknown Object (File)
Sat, Apr 26, 12:36 PM
Unknown Object (File)
Wed, Apr 23, 5:25 AM
Unknown Object (File)
Wed, Apr 23, 4:00 AM
Unknown Object (File)
Wed, Apr 23, 2:50 AM
Unknown Object (File)
Wed, Apr 23, 12:05 AM
Unknown Object (File)
Wed, Apr 16, 9:14 PM
Subscribers

Details

Reviewers
emaste
markj
Group Reviewers
Klara
Summary

PR: 285630
Sponsored by: Klara, Inc.
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63243
Build 60127: arc lint + arc unit

Event Timeline

This would break the test case mentioned in D49492, where makefs ignores the time in the mtree file.
If this is the desired behavior, the test should be updated accordingly.

This would break the test case mentioned in D49492, where makefs ignores the time in the mtree file.
If this is the desired behavior, the test should be updated accordingly.

Are you referring to the test case you sketched here? https://reviews.freebsd.org/D49492#1131965

I'm having trouble seeing the problem, given that this revision is intended to apply after D49531 -- could you please explain further?

This would break the test case mentioned in D49492, where makefs ignores the time in the mtree file.
If this is the desired behavior, the test should be updated accordingly.

Are you referring to the test case you sketched here? https://reviews.freebsd.org/D49492#1131965

Originally yes.

I'm having trouble seeing the problem, given that this revision is intended to apply after D49531 -- could you please explain further?

I tried applying the entire revision stack, but other tests failed. My main concern was that the test described in https://reviews.freebsd.org/D49492#1131965 was missed, but that is no longer the case. Thank you!

This would break the test case mentioned in D49492, where makefs ignores the time in the mtree file.
If this is the desired behavior, the test should be updated accordingly.

Are you referring to the test case you sketched here? https://reviews.freebsd.org/D49492#1131965

Originally yes.

I'm having trouble seeing the problem, given that this revision is intended to apply after D49531 -- could you please explain further?

I tried applying the entire revision stack, but other tests failed.

I believe only because they're flagged as being expected to fail, but they no longer fail. I will take a closer look tomorrow.

My main concern was that the test described in https://reviews.freebsd.org/D49492#1131965 was missed, but that is no longer the case. Thank you!

This revision is now accepted and ready to land.Wed, Apr 30, 1:29 PM