LinuxKPi: lkpi___kmalloc change a < into <= for proper boundry check
ClosedPublic
Actions

Authored by bz on Sat, Mar 29, 6:29 PM.

Details

Reviewers

emaste
jhb
dumbbell

Group Reviewers

linuxkpi

Commits

rG19efc9e6320a: LinuxKPi: lkpi___kmalloc change a < into <= for proper boundry check

Summary

lkpi___kmalloc() would use contigmalloc if the requested size is exactly
PAGE_SIZE. But we can still fullfill this request from malloc() without
losing the guarantee of physical contiguous memory.

Sponsored by: The FreeBSD Foundation
Reported by: emaste (in D46656)
Fixes: 19df0c5abcb9d
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Sat, Mar 29, 6:29 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Mar 29, 6:29 PM

bz requested review of this revision.Sat, Mar 29, 6:29 PM

Harbormaster completed remote builds in B63196: Diff 152845.Sat, Mar 29, 6:30 PM

bz added a child revision: D46657: LinuxKPI: switch mallocarray to an lpi implementation using __kmalloc().Sat, Mar 29, 6:38 PM

bz added a parent revision: D49569: LinuxKPI: be more verbose on _bus_dmamap_load_phys failures if debug is on.

dumbbell accepted this revision.Sun, Mar 30, 10:57 AM

This revision is now accepted and ready to land.Sun, Mar 30, 10:57 AM

emaste accepted this revision.Sun, Mar 30, 2:23 PM

Closed by commit rG19efc9e6320a: LinuxKPi: lkpi___kmalloc change a < into <= for proper boundry check (authored by bz). · Explain WhyTue, Apr 1, 2:42 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG19efc9e6320a: LinuxKPi: lkpi___kmalloc change a < into <= for proper boundry check.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

linux_slab.c

2 lines

Diff 152988

View Options

sys/compat/linuxkpi/common/src/linux_slab.c

LinuxKPi: lkpi___kmalloc change a < into <= for proper boundry checkClosedPublicActions