Page MenuHomeFreeBSD
Differential D49530

ipmi: fix runtime on powerpc64le
ClosedPublic
Actions

Authored by pkubaj on Thu, Mar 27, 11:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 6:27 AM
Unknown Object (File)
Sun, Mar 30, 12:52 PM
Unknown Object (File)
Sun, Mar 30, 11:49 AM
Unknown Object (File)
Sat, Mar 29, 3:52 PM
Unknown Object (File)
Sat, Mar 29, 2:36 PM
Unknown Object (File)
Sat, Mar 29, 2:03 PM
Unknown Object (File)
Sat, Mar 29, 12:01 PM
Unknown Object (File)
Sat, Mar 29, 6:53 AM
View All 9 Files
Subscribers
imp
jhibbits

Details

Reviewers
jhibbits
Group Reviewers
PowerPC
Commits
rG1e84a6ba21fd: ipmi: fix runtime on powerpc64le
rG2e16618fe789: ipmi: fix runtime on powerpc64le
Summary

OPAL runs in big-endian mode, so we need to byteswap msg_len on little-endian.

MFC after: 1 week

Test Plan

ipmitool lan print

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pkubaj created this revision.Thu, Mar 27, 11:57 AM
Herald added a subscriber: imp. · View Herald TranscriptThu, Mar 27, 11:57 AM
pkubaj requested review of this revision.Thu, Mar 27, 11:57 AM
Harbormaster completed remote builds in B63149: Diff 152735.Thu, Mar 27, 11:57 AM
jhibbits accepted this revision.Thu, Mar 27, 1:10 PM
jhibbits added a subscriber: jhibbits.

Slightly cleaner would be to use a local variable for msg_len, and write it out at the end, but this is fine.

This revision is now accepted and ready to land.Thu, Mar 27, 1:10 PM
Closed by commit rG2e16618fe789: ipmi: fix runtime on powerpc64le (authored by pkubaj). · Explain WhyThu, Mar 27, 1:19 PM
This revision was automatically updated to reflect the committed changes.
pkubaj added a commit: rG2e16618fe789: ipmi: fix runtime on powerpc64le.
pkubaj added a commit: rG1e84a6ba21fd: ipmi: fix runtime on powerpc64le.Thu, Apr 3, 10:22 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
ipmi/
1 line

Diff 152736

View Options

sys/dev/ipmi/ipmi_opal.c

Loading...