openssh: Request the OpenSSL 1.1 API

[jlduran]

Summary

Upstream OpenSSH commit f51423bda ("request 1.1x API compatibility for
OpenSSL >=3.x") requests OPENSSL_API_COMPAT version 0x10100000L (OpenSSL
1.1.0), in order to avoid warnings about deprecated functions.

Do the same here, to avoid getting those warnings.

[emaste]

What do you think of just adding it in secure/ssh.mk?

[jlduran]

In D49517#1129003, @emaste wrote:

What do you think of just adding it in secure/ssh.mk?

Yes, that was my first attempt, I thought requesting the API only where needed would be preferred. Thinking about it, it should apply to the entire OpenSSH, so better do it in secure/ssh.mk.
Will change it!

[jlduran]

Request the API globally.

[emaste]

I thought requesting the API only where needed would be preferred.

This was my thinking early on for these sorts of things as well, but doing it as in your updated diff is both simpler and safer. I think the only downside will be the somewhat longer compiler command lines (when looking at logs etc.)

[jlduran]

Only for statistical reference:
https://ci.freebsd.org/job/FreeBSD-main-amd64-build/31456/warnings10Result/fixed/

D49516 should trim the warnings down a little more.