Paths

Table of Contentst

Make temp option for ndp work
Needs ReviewPublic
Actions

Authored by lytboris_gmail.com on Sun, Mar 23, 8:20 AM.

Tags

Referenced Files

	Unknown Object (File)
	Sun, Mar 30, 12:25 AM

	Unknown Object (File)
	Sat, Mar 29, 4:23 PM

	Unknown Object (File)
	Sat, Mar 29, 11:09 AM

	Unknown Object (File)
	Fri, Mar 28, 10:02 PM

	Unknown Object (File)
	Fri, Mar 28, 10:02 PM

	Unknown Object (File)
	Fri, Mar 28, 10:02 PM

	Unknown Object (File)
	Fri, Mar 28, 10:02 PM

	Unknown Object (File)
	Fri, Mar 28, 10:02 PM

View All 9 Files

Subscribers

imp

Details

Reviewers

melifaro
glebius

Summary

Both ways to create an artificial NDP record are broken: a call via rtsock sets wrong timeout, a netlink code does not check opts.expire_time value at all.

Patch addresses both issues.

Test Plan

add 2001:DB8::/64 to an interface
run ndp -s 2001:DB8::c001 11:22:33:44:55:66 temp
check ndp -an | fgrep 2001:DB8::c001 to have < 20 minutes timeout
rebuild ndp with -DWITHOUT_NETLINK=1 and repeat steps 1-3

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

lytboris_gmail.com created this revision.Sun, Mar 23, 8:20 AM

Herald added a subscriber: imp. · View Herald TranscriptSun, Mar 23, 8:20 AM

lytboris_gmail.com requested review of this revision.Sun, Mar 23, 8:20 AM

lytboris_gmail.com added a parent revision: D43983: arp: fix arp -s/-S.Sun, Mar 23, 8:28 AM

ae added a reviewer: glebius.Sun, Mar 23, 8:28 AM

Thank you for working on this! Can we add tests here?

Revision Contents
Changeset List

Path

Size

usr.sbin/

ndp/

ndp.c

11 lines

ndp_netlink.c

18 lines

Diff 152548

View Options

usr.sbin/ndp/ndp.c