devel/subversion{,-lts}: Band-aid port option BDB and deprecate for removal

[michaelo]

Summary

• Limit BDB to supported versions (4+) by Subversion only
• Pass mandatory configure option
• Band-aid when enabled for some combinations with devel/apr1 and bdb in DEFAULT_VERSIONS
• Deprecate it as it is deprecated upstream already for almost 12 years and about to be removed in 1.15

PR: 285495
Tested by: michaelo
Approved by: jrm (mentor), otis (mentor)

[jrm]

devel/subversion-lts/Makefile

110

That leading -a looks suspicious.

devel/subversion-lts/Makefile.common

30–31

I think you could also do:

BBDB_CONFIGURE_WITH=   berkley-db
BBDB_CONFIGURE_ENABLE= bdb6

That will turn those both off when the option is off. If you decide to go with this, please confirm it's correct.

devel/subversion/Makefile

109

Same comment about leading -a.

devel/subversion/Makefile.common

30–31

Same comment from the -lts port.

[michaelo]

Fix invalid test condition

[michaelo]

devel/subversion-lts/Makefile.common

30–31

Good tip, let me evaluate this one.

[michaelo]

Add improvements from @jrm.