snd_hda: Enable microphone redirection for ALC257
Needs ReviewPublic
Actions

Authored by christos on Mon, Mar 17, 8:12 PM.

Details

Reviewers

markj
emaste
wulf
mav

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62943
Build 59827: arc lint + arc unit

Event Timeline

christos created this revision.Mon, Mar 17, 8:12 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Mar 17, 8:12 PM

christos requested review of this revision.Mon, Mar 17, 8:12 PM

Harbormaster completed remote builds in B62943: Diff 152360.Mon, Mar 17, 8:12 PM

@wulf Is this change breaking something on your device?

christos mentioned this in D49002: snd_hda(4): Add quirks for Lenovo ThinkBooks and ASUS TUFs.Mon, Mar 17, 8:13 PM

christos added a child revision: D49002: snd_hda(4): Add quirks for Lenovo ThinkBooks and ASUS TUFs.

As with any other patches of the kind you may either fix the "issue" or break sound completely by producing invalid configuration. Unless the configuration is already broken and require fixing, it should better be handled with /dev/dsp redirection, as we discussed before.

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pci/

hda/

hdaa_patches.c

7 lines

hdac.h

1 line

Diff 152360

View Options

sys/dev/sound/pci/hda/hdaa_patches.c