sockbuf: provide sbunreserve_locked() which is a complement to sbreserve()
AcceptedPublic
Actions

Authored by glebius on Fri, Mar 14, 6:06 PM.

Details

Reviewers

Group Reviewers

Summary

The sbreserve() works only on protocol-independent parts of the sockbuf,
but sbrelease() also clears the generic sockbuf mbuf chain. Calling the
latter to undo changes done by the former is not correct. The new
function is the right thing.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62923
Build 59807: arc lint + arc unit

Event Timeline

glebius created this revision.Fri, Mar 14, 6:06 PM

Herald added subscribers: olce, imp. · View Herald TranscriptFri, Mar 14, 6:06 PM

glebius requested review of this revision.Fri, Mar 14, 6:06 PM

Harbormaster completed remote builds in B62923: Diff 152271.Fri, Mar 14, 6:07 PM

glebius added a parent revision: D49363: sockbuf: remove sbflush_internal() and sbrelease_internal() shims.Fri, Mar 14, 6:07 PM

The sbreserve() works only on protocol-independent parts of the sockbuf

Typo, soreserve().

This revision is now accepted and ready to land.Mon, Mar 17, 7:28 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_sockbuf.c

19 lines

Diff 152271

View Options

sockbuf: provide sbunreserve_locked() which is a complement to sbreserve()AcceptedPublicActions