dev: Use recently added improvements to PME# support to simplify drivers
ClosedPublic
Actions

Authored by jhb on Mar 5 2025, 9:55 PM.

Details

Reviewers

imp
krzysztof.galazka_intel.com

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rGddaf6524682b: dev: Use recently added improvements to PME# support to simplify drivers

Summary

Depend on the PCI bus driver clearing PME# after resume to remove the
need for clearing PME# from DEVICE_RESUME methods.

Use pci_has_pm and pci_enable_pme.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62776
Build 59660: arc lint + arc unit

Event Timeline

jhb created this revision.Mar 5 2025, 9:55 PM

Owners added a reviewer: Restricted Owners Package.Mar 5 2025, 9:55 PM

Harbormaster completed remote builds in B62776: Diff 151932.Mar 5 2025, 9:55 PM

jhb requested review of this revision.Mar 5 2025, 9:55 PM

jhb added a parent revision: D49250: pci: Add helper routines to manage PME in device drivers.

jhb added a child revision: D49266: acpi_pci: Use pci_has_pm and pci_clear_pme.Mar 6 2025, 6:23 PM

Looks good to me. Unfortunately I don't have any EM HW to test it.

This revision is now accepted and ready to land.Mar 7 2025, 8:09 PM

jhb closed this revision.Mar 28 2025, 3:48 PM

jhb added a commit: rGddaf6524682b: dev: Use recently added improvements to PME# support to simplify drivers.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ae/

if_ae.c

15 lines

age/

if_age.c

15 lines

if_agevar.h

1 line

alc/

if_alc.c

32 lines

if_alcvar.h

1 line

ale/

if_ale.c

28 lines

if_alevar.h

1 line

e1000/

if_em.c

10 lines

fxp/

if_fxp.c

34 lines

igc/

if_igc.c

10 lines

jme/

if_jme.c

26 lines

if_jmevar.h

1 line

nfe/

if_nfe.c

11 lines

nge/

if_nge.c

23 lines

re/

if_re.c

14 lines

rl/

if_rl.c

27 lines

sis/

if_sis.c

15 lines

ste/

if_ste.c

25 lines

vge/

if_vge.c

23 lines

if_vgevar.h

1 line

vr/

if_vr.c

16 lines

xl/

if_xl.c

16 lines

if_xlreg.h

1 line

Diff 151932

View Options

sys/dev/ae/if_ae.c

View Options

sys/dev/age/if_age.c

View Options

sys/dev/age/if_agevar.h

View Options

sys/dev/alc/if_alc.c

View Options

sys/dev/alc/if_alcvar.h

View Options

sys/dev/ale/if_ale.c

View Options

sys/dev/ale/if_alevar.h

View Options

sys/dev/e1000/if_em.c

View Options

sys/dev/fxp/if_fxp.c

View Options

sys/dev/igc/if_igc.c

View Options

sys/dev/jme/if_jme.c

View Options

sys/dev/jme/if_jmevar.h

View Options

sys/dev/nfe/if_nfe.c

View Options

sys/dev/nge/if_nge.c

View Options

sys/dev/re/if_re.c

View Options

sys/dev/rl/if_rl.c

View Options

sys/dev/sis/if_sis.c

View Options

sys/dev/ste/if_ste.c

View Options

sys/dev/vge/if_vge.c

View Options

sys/dev/vge/if_vgevar.h

View Options

sys/dev/vr/if_vr.c

View Options

sys/dev/xl/if_xl.c

View Options

dev: Use recently added improvements to PME# support to simplify driversClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 151932

sys/dev/ae/if_ae.c

sys/dev/age/if_age.c

sys/dev/age/if_agevar.h

sys/dev/alc/if_alc.c

sys/dev/alc/if_alcvar.h

sys/dev/ale/if_ale.c

sys/dev/ale/if_alevar.h

sys/dev/e1000/if_em.c

sys/dev/fxp/if_fxp.c

sys/dev/igc/if_igc.c

sys/dev/jme/if_jme.c

sys/dev/jme/if_jmevar.h

sys/dev/nfe/if_nfe.c

sys/dev/nge/if_nge.c

sys/dev/re/if_re.c

sys/dev/rl/if_rl.c

sys/dev/sis/if_sis.c

sys/dev/ste/if_ste.c

sys/dev/vge/if_vge.c

sys/dev/vge/if_vgevar.h

sys/dev/vr/if_vr.c

sys/dev/xl/if_xl.c

sys/dev/xl/if_xlreg.h

dev: Use recently added improvements to PME# support to simplify drivers
ClosedPublic
Actions

Revision Contents
Changeset List