Differential D49242

libdtrace: Fix an off-by-one in the priority queue implementation
ClosedPublic
Actions

Authored by markj on Wed, Mar 5, 10:59 AM.

Details

Reviewers

gnn

Group Reviewers

DTrace

Commits

rG7ee1bdd094d3: libdtrace: Fix an off-by-one in the priority queue implementation

Summary

The zero'th index in the array is unused, so a priority queue of N elements
needs N+1 array slots. Fix the allocation.

Also fix the assertion in dt_pq_insert(): the assertion needs to be checked
after incrementing the count of items in the priority queue, otherwise it can
miss an overflow.

Reported by: CHERI
Sponsored by: Innovate UK

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62768
Build 59652: arc lint + arc unit

Event Timeline

markj created this revision.Wed, Mar 5, 10:59 AM

Herald added a reviewer: gnn. · View Herald TranscriptWed, Mar 5, 10:59 AM

Herald added a subscriber: imp. · View Herald Transcript

markj requested review of this revision.Wed, Mar 5, 10:59 AM

Harbormaster completed remote builds in B62768: Diff 151910.Wed, Mar 5, 10:59 AM

markj added a child revision: D49243: libdtrace: Fix an off-by-one in CPU ID handling.Wed, Mar 5, 10:59 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Mar 10, 3:04 AM

Closed by commit rG7ee1bdd094d3: libdtrace: Fix an off-by-one in the priority queue implementation (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG7ee1bdd094d3: libdtrace: Fix an off-by-one in the priority queue implementation.

Revision Contents
Changeset List

Path

Size

cddl/

contrib/

opensolaris/

lib/

libdtrace/

common/

dt_pq.c

6 lines

Diff 151910

View Options

cddl/contrib/opensolaris/lib/libdtrace/common/dt_pq.c

libdtrace: Fix an off-by-one in the priority queue implementationClosedPublicActions