Page MenuHomeFreeBSD
Differential D49234

net80211: Fix IEEE80211_KEY_UNDEFINED() in ieee80211_node_delucastkey()
ClosedPublic
Actions

Authored by bz on Wed, Mar 5, 12:06 AM.
Tags
None
Referenced Files
F112547927: D49234.diff
Wed, Mar 19, 4:56 PM
Unknown Object (File)
Wed, Mar 12, 3:02 AM
Unknown Object (File)
Sat, Mar 8, 8:55 AM
Unknown Object (File)
Fri, Mar 7, 4:01 AM
Unknown Object (File)
Thu, Mar 6, 8:18 PM
Unknown Object (File)
Thu, Mar 6, 7:35 PM
Unknown Object (File)
Thu, Mar 6, 5:24 PM
Unknown Object (File)
Thu, Mar 6, 2:53 PM
View All 16 Files
Subscribers
adrian
glebius
imp
melifaro

Details

Reviewers
takahiro.kurosawa_gmail.com
adrian
Group Reviewers
wireless
Commits
rG27bf5c405bf2: net80211: Fix IEEE80211_KEY_UNDEFINED() in ieee80211_node_delucastkey()
Summary

The adjustment of the check inverted the logic. Fix this.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Fixes: 9763fec11b83
Reported by: KUROSAWA Takahiro (takahiro.kurosawa gmail.com) in D48980

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 62758
Build 59642: arc lint + arc unit

Event Timeline

bz created this revision.Wed, Mar 5, 12:06 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptWed, Mar 5, 12:06 AM
bz requested review of this revision.Wed, Mar 5, 12:06 AM
Harbormaster completed remote builds in B62758: Diff 151877.Wed, Mar 5, 12:06 AM
bz mentioned this in D48980: net80211: use IEEE80211_KEY_UNDEFINED() insetad of checking they keyix.Wed, Mar 5, 12:07 AM
adrian accepted this revision.Wed, Mar 5, 12:09 AM
adrian added a subscriber: adrian.

oops!

This revision is now accepted and ready to land.Wed, Mar 5, 12:09 AM
takahiro.kurosawa_gmail.com accepted this revision.Wed, Mar 5, 12:16 AM

Thanks for fixing!
I've been running the kernel that has exactly the same fix and confirmed the problem I had was fixed.

adrian added a comment.Wed, Mar 5, 3:36 PM

I just hit this with key referencing and running this patch locally fixed it.

bz, wanna land it? Thanks!

bz added a comment.Wed, Mar 5, 9:17 PM
In D49234#1123120, @adrian wrote:

I just hit this with key referencing and running this patch locally fixed it.

bz, wanna land it? Thanks!

Yes, I will; I was AFK today.

How do you notice? If you say you hit it. Do we log an error? STA or AP mode?

Closed by commit rG27bf5c405bf2: net80211: Fix IEEE80211_KEY_UNDEFINED() in ieee80211_node_delucastkey() (authored by bz). · Explain WhyWed, Mar 5, 9:19 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG27bf5c405bf2: net80211: Fix IEEE80211_KEY_UNDEFINED() in ieee80211_node_delucastkey().
adrian added a comment.Wed, Mar 5, 11:20 PM
In D49234#1123174, @bz wrote:
In D49234#1123120, @adrian wrote:

I just hit this with key referencing and running this patch locally fixed it.

bz, wanna land it? Thanks!

Yes, I will; I was AFK today.

How do you notice? If you say you hit it. Do we log an error? STA or AP mode?

Amusingly whilst debugging the ccmp/gcmp stuff. When I went to unload the ccmp module it complained about the reference count being wrong, even though I had deleted the vap (so any keys should have been deleted.)

bz added a comment.Thu, Mar 6, 9:54 AM
In D49234#1123219, @adrian wrote:
In D49234#1123174, @bz wrote:
In D49234#1123120, @adrian wrote:

I just hit this with key referencing and running this patch locally fixed it.

bz, wanna land it? Thanks!

Yes, I will; I was AFK today.

How do you notice? If you say you hit it. Do we log an error? STA or AP mode?

Amusingly whilst debugging the ccmp/gcmp stuff. When I went to unload the ccmp module it complained about the reference count being wrong, even though I had deleted the vap (so any keys should have been deleted.)

Interesting. I'll need more reading on key updates. We should be able to detect that case at run time failing as well I suppose. Wireless was so simple 25 years ago ...

Revision Contents
Changeset List

PathSize
sys/
net80211/
2 lines

Diff 151877

View Options

sys/net80211/ieee80211_node.c

Loading...