Page MenuHomeFreeBSD
Differential D49227

udp: Do not recursively enter net epoch
ClosedPublic
Actions

Authored by zlei on Tue, Mar 4, 9:51 AM.
Tags
None
Referenced Files
F112680712: D49227.id151834.diff
Fri, Mar 21, 9:07 AM
Unknown Object (File)
Fri, Mar 14, 10:57 AM
Unknown Object (File)
Sat, Mar 8, 12:44 AM
Unknown Object (File)
Fri, Mar 7, 9:43 AM
Unknown Object (File)
Fri, Mar 7, 5:17 AM
Unknown Object (File)
Fri, Mar 7, 5:03 AM
Unknown Object (File)
Fri, Mar 7, 3:52 AM
Unknown Object (File)
Thu, Mar 6, 7:33 AM
View All 16 Files
Subscribers
imp
melifaro

Details

Reviewers
glebius
ae
Group Reviewers
network
transport
Commits
rGaf1bd15d3be3: udp: Do not recursively enter net epoch
rG2472f4dbe930: udp: Do not recursively enter net epoch
Summary

The only caller udp_send() has already entered net epoch before invoking
udp_v4mapped_pktinfo().

No functional change intended.

This partially reverts commit d74b7baeb0d4 (ifnet_byindex() actually
requires network epoch).

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Tue, Mar 4, 9:51 AM
Herald added a reviewer: transport. · View Herald TranscriptTue, Mar 4, 9:51 AM
Herald added subscribers: melifaro, imp. · View Herald Transcript
zlei requested review of this revision.Tue, Mar 4, 9:51 AM
ae accepted this revision as: ae.Tue, Mar 4, 11:56 AM
glebius accepted this revision as: glebius.Tue, Mar 4, 6:22 PM

Didn't do a full examination of all stacks, the change by itself should be correct. If any code path triggers the new assertion, that path needs to be fixed.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Mar 5, 5:01 AM
Closed by commit rG2472f4dbe930: udp: Do not recursively enter net epoch (authored by zlei). · Explain Why
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rG2472f4dbe930: udp: Do not recursively enter net epoch.
zlei added a comment.Wed, Mar 5, 5:13 AM
In D49227#1122827, @glebius wrote:

Didn't do a full examination of all stacks, the change by itself should be correct. If any code path triggers the new assertion, that path needs to be fixed.

I noticed this while checking the usage of IN6_IS_ADDR_UNSPECIFIED().

There're still some, notably bpf(4). Well that has been in WIP for quite a long time. I started that when I was working on D39275. I'll post when ready.

zlei added a commit: rGaf1bd15d3be3: udp: Do not recursively enter net epoch.Thu, Mar 13, 10:14 AM

Revision Contents
Changeset List

PathSize
sys/
netinet/
6 lines

Diff 151886

View Options

sys/netinet/udp_usrreq.c

Loading...