Page MenuHomeFreeBSD
Differential D49226

netlink: Fix getting route scope of interface's IPv4 addresses
ClosedPublic
Actions

Authored by zlei on Tue, Mar 4, 7:02 AM.
Tags
None
Referenced Files
F112547935: D49226.diff
Wed, Mar 19, 4:56 PM
F112534476: D49226.id151833.diff
Wed, Mar 19, 11:53 AM
Unknown Object (File)
Wed, Mar 12, 8:34 PM
Unknown Object (File)
Sat, Mar 8, 5:00 PM
Unknown Object (File)
Fri, Mar 7, 3:48 PM
Unknown Object (File)
Fri, Mar 7, 2:01 PM
Unknown Object (File)
Fri, Mar 7, 10:21 AM
Unknown Object (File)
Fri, Mar 7, 7:05 AM
View All 16 Files
Subscribers
franco_opnsense.org
glebius
imp
jlduran

Details

Reviewers
melifaro
glebius
Group Reviewers
network
Commits
rG6771ec1d6a50: netlink: Fix getting route scope of interface's IPv4 addresses
rG9f26a03fdbdc: tests/netlink: Assert the route scope of interface's addresses
rG057165012b4d: netlink: Fix getting route scope of interface's IPv4 addresses
rGe84a17db1cc0: tests/netlink: Assert the route scope of interface's addresses
rG0e096bb3fcaa: netlink: Fix getting route scope of interface's IPv4 addresses
rG5d8b48487acc: tests/netlink: Assert the route scope of interface's addresses
Summary
netlink: Fix getting route scope of interface's IPv4 addresses

sin_addr of a `struct sockaddr_in` is stored in network byte order, but
IN_LOOPBACK() and IN_LINKLOCAL() want the host order.

Fixes:  7e5bf68495cc netlink: add netlink support
MFC after:      3 days
tests/netlink: Assert the route scope of interfaces's addresses

While here, add IPv4 link-local address to cover RT_SCOPE_LINK case.

MFC after:      3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei created this revision.Tue, Mar 4, 7:02 AM
Herald added subscribers: glebius, imp. · View Herald TranscriptTue, Mar 4, 7:02 AM
zlei requested review of this revision.Tue, Mar 4, 7:02 AM
zlei mentioned this in D49053: carp: Fix checking IPv4 multicast address.Tue, Mar 4, 7:06 AM
zlei added a reviewer: glebius.Tue, Mar 4, 7:10 AM
franco_opnsense.org added a subscriber: franco_opnsense.org.Tue, Mar 4, 7:16 AM
jlduran added a subscriber: jlduran.Wed, Mar 5, 3:07 AM

Nice! Thank you!

melifaro accepted this revision.Thu, Mar 6, 9:17 AM

LGTM, thank you!

This revision is now accepted and ready to land.Thu, Mar 6, 9:17 AM
glebius added a comment.Thu, Mar 6, 11:13 PM

Zhenlei, please go forward with Alexander's review, don't wait on me. Thanks!

zlei added a comment.Thu, Mar 6, 11:26 PM
In D49226#1123621, @glebius wrote:

Zhenlei, please go forward with Alexander's review, don't wait on me. Thanks!

Yeah, I'm going to commit today (UTC+8). I'm not familiar with Python. The fix is simple but I spent a lot time on the tests :-)

Closed by commit rG5d8b48487acc: tests/netlink: Assert the route scope of interface's addresses (authored by zlei). · Explain WhyFri, Mar 7, 4:15 AM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rG5d8b48487acc: tests/netlink: Assert the route scope of interface's addresses.
zlei added a commit: rG0e096bb3fcaa: netlink: Fix getting route scope of interface's IPv4 addresses.
zlei added a commit: rGe84a17db1cc0: tests/netlink: Assert the route scope of interface's addresses.Mon, Mar 10, 10:14 AM
zlei added a commit: rG057165012b4d: netlink: Fix getting route scope of interface's IPv4 addresses.
zlei added a commit: rG9f26a03fdbdc: tests/netlink: Assert the route scope of interface's addresses.Mon, Mar 10, 10:24 AM
zlei added a commit: rG6771ec1d6a50: netlink: Fix getting route scope of interface's IPv4 addresses.

Revision Contents
Changeset List

PathSize
sys/
netlink/
route/
4 lines
tests/
sys/
netlink/
20 lines

Diff 151833

View Options

sys/netlink/route/iface.c

Loading...
View Options

tests/sys/netlink/test_rtnl_ifaddr.py

Loading...