Paths

Table of Contentst

Differential D49204

ports.7: Update dialog4ports to portconfig
ClosedPublic
Actions

Authored by ziaee on Sun, Mar 2, 9:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Mar 21, 7:56 PM

	Unknown Object (File)
	Fri, Mar 7, 12:23 PM

	Unknown Object (File)
	Thu, Mar 6, 7:25 PM

	Unknown Object (File)
	Thu, Mar 6, 10:34 AM

	Unknown Object (File)
	Thu, Mar 6, 12:36 AM

	Unknown Object (File)
	Wed, Mar 5, 9:48 PM

	Unknown Object (File)
	Wed, Mar 5, 3:40 PM

	Unknown Object (File)
	Wed, Mar 5, 3:09 AM

View All 12 Files

Subscribers

Details

Reviewers

carlavilla
mhorne
bapt

Group Reviewers

Ports Committers
manpages

Commits

rG69569859a0a4: ports.7: Update dialog4ports to portconfig
rG26a7022d62b8: ports.7: Update dialog4ports to portconfig
rG3bf433f141a5: ports.7: Update dialog4ports to portconfig

Summary

dialog4ports has been replaced with portconfig for several years.
It was marked as deprecated and broken in ports:61e4a788ecab.
While here, tag SPDX.

MFC after: 3 days
Reported by: Community Discord

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62727
Build 59611: arc lint + arc unit

Event Timeline

ziaee created this revision.Sun, Mar 2, 9:40 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, Mar 2, 9:40 PM

ziaee requested review of this revision.Sun, Mar 2, 9:40 PM

Harbormaster completed remote builds in B62727: Diff 151756.Sun, Mar 2, 9:40 PM

ziaee added inline comments.Sun, Mar 2, 9:43 PM

share/man/man7/ports.7
166	I'm not sure that we really want to do it this way and don't instead want to do this? The suggestion in this comment is more correct in my opinion, but I used the style this page is written in the draft commit.

ziaee edited the summary of this revision. (Show Details)Sun, Mar 2, 10:42 PM

Bump date and tag spdx.

Harbormaster completed remote builds in B62728: Diff 151757.Sun, Mar 2, 10:51 PM

ziaee edited the summary of this revision. (Show Details)Sun, Mar 2, 10:51 PM

bapt accepted this revision.Thu, Mar 6, 8:06 PM

This revision is now accepted and ready to land.Thu, Mar 6, 8:06 PM

mhorne added inline comments.Fri, Mar 21, 2:46 PM

share/man/man7/ports.7
166	There is a precedent to xref manpages coming from ports in this manner, e.g. references to `kgdb(1)` in `ddb(4)`. It is not codified anywhere. I think it would be a good addition to `style.mdoc(5)`, but I do not ask you to take this on immediately (in fact I might).

I like that, that's very nice and clear.

This revision now requires review to proceed.Fri, Mar 21, 5:08 PM

Harbormaster completed remote builds in B63034: Diff 152508.Fri, Mar 21, 5:08 PM

Approved.

This revision is now accepted and ready to land.Fri, Mar 21, 5:48 PM

Closed by commit rG3bf433f141a5: ports.7: Update dialog4ports to portconfig (authored by ziaee). · Explain WhyFri, Mar 21, 7:30 PM

This revision was automatically updated to reflect the committed changes.

ziaee added a commit: rG3bf433f141a5: ports.7: Update dialog4ports to portconfig.

ziaee added a commit: rG26a7022d62b8: ports.7: Update dialog4ports to portconfig.Mon, Mar 24, 1:41 AM

ziaee added a commit: rG69569859a0a4: ports.7: Update dialog4ports to portconfig.Mon, Mar 24, 1:44 AM

Revision Contents
Changeset List

Path

Size

share/

man/

man7/

4 lines

Diff 151756

share/man/man7/ports.7

Loading...