Differential D49195

pci(4): Give UEFI wiring example
ClosedPublic
Actions

Authored by imp on Sat, Mar 1, 10:20 PM.

Tags

None

Referenced Files

	F112657741: D49195.diff
	Fri, Mar 21, 2:14 AM

	Unknown Object (File)
	Fri, Mar 14, 7:05 PM

	Unknown Object (File)
	Fri, Mar 14, 1:13 PM

	Unknown Object (File)
	Wed, Mar 12, 10:40 AM

	Unknown Object (File)
	Thu, Mar 6, 3:28 AM

	Unknown Object (File)
	Wed, Mar 5, 8:47 PM

	Unknown Object (File)
	Mon, Mar 3, 8:49 PM

	Unknown Object (File)
	Mon, Mar 3, 8:49 PM

View All 17 Files

Subscribers

Details

Reviewers

Commits

rG23da585dd465: pci(4): Give UEFI wiring example

Summary

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62715
Build 59599: arc lint + arc unit

Event Timeline

imp created this revision.Sat, Mar 1, 10:20 PM

Herald added a subscriber: ziaee. · View Herald TranscriptSat, Mar 1, 10:20 PM

imp requested review of this revision.Sat, Mar 1, 10:20 PM

Harbormaster completed remote builds in B62715: Diff 151725.Sat, Mar 1, 10:20 PM

Wow, what a great feature, and a glorious addition to the manual!

share/man/man4/pci.4
375	mandoc is complaining about a tab in this line somewhere?
438	Probably out of scope, but this and the above would eliminate compiler WARNINGs.
627
631
646
667	Since this the display block below is 81 columns, how do you feel about not offsetting these?
670
677	How do you feel about using "device"? In my handbook/X11 draft I removed all mentions of card because I think devices are not always or even usually cards. This is less true with nvme than it was for graphics, but there is still plenty of embedded or U.3.
686–689	Maybe? Also, should this part go in a new paragraph after 663? I think it's really nice when the beginning of a section or subsection explains what it is, instead of why.
694–696	Maybe?
698–699
702
709–710	Maybe?
718	Does it make sense to put device.hints(5) down here too?

update relevant comments...

Harbormaster completed remote builds in B62722: Diff 151741.Sun, Mar 2, 4:42 AM

imp added inline comments.Sun, Mar 2, 4:42 AM

share/man/man4/pci.4
375	Out of scope.
438	out of scope.
667	Don't know. Will eave to others.

ziaee accepted this revision.Sun, Mar 2, 5:17 AM

This revision is now accepted and ready to land.Sun, Mar 2, 5:17 AM

Closed by commit rG23da585dd465: pci(4): Give UEFI wiring example (authored by imp). · Explain WhySun, Mar 2, 5:19 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG23da585dd465: pci(4): Give UEFI wiring example.

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

38 lines

Diff 151725

share/man/man4/pci.4

Loading...