Page MenuHomeFreeBSD

smbios: Unmap memory on error on identify
ClosedPublic

Authored by olce on Feb 28 2025, 6:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 9:40 PM
Unknown Object (File)
Thu, Apr 10, 11:22 AM
Unknown Object (File)
Tue, Apr 8, 12:30 AM
Unknown Object (File)
Mar 26 2025, 3:43 AM
Unknown Object (File)
Mar 25 2025, 8:42 PM
Unknown Object (File)
Mar 15 2025, 7:37 PM
Unknown Object (File)
Mar 11 2025, 1:55 PM
Unknown Object (File)
Mar 11 2025, 1:01 AM
Subscribers

Details

Summary

While here, de-indent most of the code by simply bailing out if 'addr'
is still 0 after the various detection methods have been tried.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62694
Build 59578: arc lint + arc unit

Event Timeline

olce requested review of this revision.Feb 28 2025, 6:10 PM

👍 for the early return

sys/dev/smbios/smbios.c
149

I recommend leaving the "unnecessary" braces around this statement -- at least, the if and else blocks are now both a single statement and should be consistent.

+1 for ed's comment other wise looks good.

This revision is now accepted and ready to land.Feb 28 2025, 6:50 PM
olce marked an inline comment as done.Feb 28 2025, 8:35 PM
olce added inline comments.
sys/dev/smbios/smbios.c
149

I've removed the braces around the "then" part (not updated now here, but will be at commit).

This revision was automatically updated to reflect the committed changes.
olce marked an inline comment as done.