netinet: Do not forward or ICMP response to INADDR_ANY
ClosedPublic
Actions

Authored by zlei on Thu, Feb 27, 3:02 PM.

Details

Reviewers

rgrimes
glebius
melifaro

Group Reviewers

network

Commits

rG9406d7e32da7: netinet: Do not forward or ICMP response to INADDR_ANY
rGf7174eb2b4c4: netinet: Do not forward or ICMP response to INADDR_ANY

Summary

The section 4 in the draft proposal [1] explicitly states that 0.0.0.0,
aka INADDR_ANY, retains its existing special meanings.

[1] https://datatracker.ietf.org/doc/draft-schoen-intarea-unicast-0

Fixes: efe58855f3ea IPv4: experimental changes to allow net 0/8, 240/4, part of 127/8
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Thu, Feb 27, 3:02 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Feb 27, 3:02 PM

zlei requested review of this revision.Thu, Feb 27, 3:02 PM

glebius accepted this revision as: glebius.Thu, Feb 27, 6:26 PM

glebius added inline comments.

sys/netinet/in.c
280	Why not using in_nullhost() here?

This revision is now accepted and ready to land.Thu, Feb 27, 6:26 PM

zlei added inline comments.Sun, Mar 2, 2:10 PM

sys/netinet/in.c
280	I'll use `in_nullhost()` when I commit. I thought `INADDR_ANY` is eye-catching :)

Closed by commit rGf7174eb2b4c4: netinet: Do not forward or ICMP response to INADDR_ANY (authored by zlei). · Explain WhySun, Mar 2, 3:03 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rGf7174eb2b4c4: netinet: Do not forward or ICMP response to INADDR_ANY.

zlei marked an inline comment as done.Sun, Mar 2, 3:04 PM

zlei added a commit: rG9406d7e32da7: netinet: Do not forward or ICMP response to INADDR_ANY.Fri, Mar 7, 4:03 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in.c

3 lines

ip_icmp.c

5 lines

Diff 151749

View Options

sys/netinet/in.c