acpi_wmi: Add type check before evaluaeting query ACPI method
ClosedPublic
Actions

Authored by takawata on Tue, Feb 25, 10:00 AM.

Details

Reviewers

avg
wulf
mav

Commits

rGf9b4092743fc: acpi_wmi: Add type check before evaluaeting query ACPI method

Summary

Some ACPI wmi query is impremented by named object, not method,
ACPICA complains when non-method object is evaluated with one or more arguments.
Especially, almost all binary MOF object obtaining method is the case.
his commit will fix it.

PR: 284912
Reported by: Alexander Ziaee

Test Plan

Reboot and make sure no ACPI warning is happend and make sure ACPI wmi child driver is not regressed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 62620
Build 59504: arc lint + arc unit

Event Timeline

takawata created this revision.Tue, Feb 25, 10:00 AM

takawata held this revision as a draft.

Herald added a subscriber: imp. · View Herald TranscriptTue, Feb 25, 10:00 AM

Harbormaster completed remote builds in B62620: Diff 151452.Tue, Feb 25, 10:00 AM

acpi_wmi: Add type check before evaluaeting query ACPI method

Some ACPI wmi query is impremented by named object, not method,
ACPICA complains when non-method object is evaluated with one or more arguments.
Especially, almost all binary MOF object obtaining method is the case.

This commit will fix it.

PR: 284912
Reported by: Alexander Ziaee

Harbormaster completed remote builds in B62621: Diff 151454.Tue, Feb 25, 10:11 AM

acpi_wmi: Add type check before evaluaeting query ACPI method

Some ACPI wmi query is impremented by named object, not method,
ACPICA complains when non-method object is evaluated with one or more arguments.
Especially, almost all binary MOF object obtaining method is the case.

This commit will fix it.

PR:     284912
Reported by:    Alexander Ziaee

Test Plan: Reboot and make sure no ACPI warning is happend and make sure ACPI wmi child driver is not regressed.

Subscribers: imp

Differential Revision: https://reviews.freebsd.org/D49129

Harbormaster completed remote builds in B62622: Diff 151455.Tue, Feb 25, 10:13 AM

takawata retitled this revision from PR: 284912 Reported by: Alexander Ziaee to acpi_wmi: Add type check before evaluaeting query ACPI method.Tue, Feb 25, 10:16 AM

takawata edited the summary of this revision. (Show Details)

takawata published this revision for review.Tue, Feb 25, 10:20 AM

takawata added reviewers: avg, wulf.

I do not have WMI client drivers to determine regressions. I have been running current with this patch for several days though on my laptop.

takawata added a reviewer: mav.Mon, Mar 3, 5:28 AM

avg added inline comments.Fri, Mar 7, 1:29 PM