bsd.mkopt.mk: Avoid warning from makeman
ClosedPublic
Actions

Authored by emaste on Mon, Feb 24, 2:03 PM.

Details

Reviewers

brooks
cperciva

Commits

rG586bdc6f7555: bsd.mkopt.mk: Avoid warning from makeman
rG085c0641a2ea: bsd.mkopt.mk: Avoid warning from makeman

Summary

Setting WITHOUT_X where X is a __REQUIRED_OPTION produces a warning.
This happened also during makeman's `make showconfig` invocatation, but
the warning serves no purpose there, and clutters makeman's output.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Mon, Feb 24, 2:03 PM

emaste created this revision.

Doesn't quite work

For reference the warning we get:

............................make[1]: "/home/emaste/src/freebsd-git/wipbsd/share/mk/bsd.mkopt.mk" line 71: warning: WITHOUT_CASPER option ignored: it is no longer supported
make[1]: "/home/emaste/src/freebsd-git/wipbsd/share/mk/bsd.mkopt.mk" line 71: warning: WITHOUT_CASPER option ignored: it is no longer supported
....................................................................................................................................................................................................................................

emaste updated this revision to Diff 151406.Mon, Feb 24, 3:33 PM

emaste retitled this revision from makeman: Avoid .warning from __REQUIRED_OPTIONS to bsd.mkopt.mk: Avoid warning from makeman.

emaste edited the summary of this revision. (Show Details)

emaste added a reviewer: cperciva.

Herald added a subscriber: bdrewery. · View Herald TranscriptMon, Feb 24, 3:33 PM

Seems reasonable.

This revision is now accepted and ready to land.Tue, Feb 25, 4:04 AM

Closed by commit rG085c0641a2ea: bsd.mkopt.mk: Avoid warning from makeman (authored by emaste). · Explain WhyTue, Feb 25, 1:11 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG085c0641a2ea: bsd.mkopt.mk: Avoid warning from makeman.

Herald added a subscriber: imp. · View Herald TranscriptTue, Feb 25, 1:11 PM

emaste added a commit: rG586bdc6f7555: bsd.mkopt.mk: Avoid warning from makeman.Fri, Feb 28, 6:20 PM