net80211: crypto: ccmp: simplify and style(9)
ClosedPublic
Actions

Authored by bz on Wed, Feb 19, 12:32 PM.

Details

Reviewers

emaste
adrian

Group Reviewers

wireless

Commits

rG8feaeb95440b: net80211: crypto: ccmp: simplify and style(9)
rG8dcdffdb0861: net80211: crypto: ccmp: simplify and style(9)

Summary

Add checks for booleaness of flag tests.
If there is no need for double negated checks simplify them.
This all makes the conditions a lot easier to read.

No functional changes.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 62513
Build 59397: arc lint + arc unit

Event Timeline

bz created this revision.Wed, Feb 19, 12:32 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptWed, Feb 19, 12:32 PM

bz requested review of this revision.Wed, Feb 19, 12:32 PM

Harbormaster completed remote builds in B62513: Diff 151176.Wed, Feb 19, 12:32 PM

👍 from De Morgan.

Maybe make the subject "simplify and style(9)", at first glance I was looking for another change in the first one other than just adding != 0

This revision is now accepted and ready to land.Wed, Feb 19, 1:43 PM

In D49055#1118572, @emaste wrote:

👍 from De Morgan.

Maybe make the subject "simplify and style(9)", at first glance I was looking for another change in the first one other than just adding != 0

Will do. Thanks.

bz retitled this revision from net80211: crypto: ccmp: simplify checks to net80211: crypto: ccmp: simplify and style(9).Wed, Feb 19, 1:57 PM

adrian accepted this revision.Wed, Feb 19, 2:58 PM

Closed by commit rG8dcdffdb0861: net80211: crypto: ccmp: simplify and style(9) (authored by bz). · Explain WhyThu, Feb 20, 6:05 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG8dcdffdb0861: net80211: crypto: ccmp: simplify and style(9).

bz added a commit: rG8feaeb95440b: net80211: crypto: ccmp: simplify and style(9).Mon, Feb 24, 8:29 PM