Page MenuHomeFreeBSD
Differential D48983

acpi_asus_wmi(4): Improve keyboard backlight support.
ClosedPublic
Actions

Authored by wulf on Feb 13 2025, 8:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 3:47 PM
Unknown Object (File)
Thu, Mar 6, 9:15 PM
Unknown Object (File)
Wed, Mar 5, 9:18 AM
Unknown Object (File)
Mon, Mar 3, 3:33 AM
Unknown Object (File)
Sat, Mar 1, 2:40 PM
Unknown Object (File)
Sat, Mar 1, 10:59 AM
Unknown Object (File)
Sat, Mar 1, 10:47 AM
Unknown Object (File)
Sat, Mar 1, 9:11 AM
View All 10 Files
Subscribers
imp
ziaee

Details

Reviewers
mav
Commits
rGf134662a1a57: acpi_asus_wmi(4): Improve keyboard backlight support.
Summary

acpi_asus_wmi(4): Fix maximal keyboard backlight level
Although Linux source code comment says that backlight level is encoded
in 3 bits of data, actual code limits maximum level to 3.

acpi_asus_wmi(4): Add backlight(9) support for keyboard

acpi_asus_wmi: turn off/on keyboard backlight on suspend/resume

Sponsored by: Future Crew LLC
MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wulf created this revision.Feb 13 2025, 8:02 AM
Herald added subscribers: ziaee, imp. · View Herald TranscriptFeb 13 2025, 8:02 AM
wulf requested review of this revision.Feb 13 2025, 8:02 AM
Harbormaster completed remote builds in B62416: Diff 150944.Feb 13 2025, 8:02 AM
mav added a comment.Feb 14 2025, 2:11 AM

I have no objections, but I wonder whether maximum of 3 vs 7 might be model-specific?

sys/dev/acpi_support/acpi_asus_wmi.c
413

Why random mix of UINT32 and uint32_t?

419–421

Braces?

ziaee added inline comments.Feb 14 2025, 3:44 AM
share/man/man4/acpi_asus_wmi.4
76
wulf updated this revision to Diff 151107.Feb 17 2025, 8:24 AM

Fix manpage and braces

Harbormaster completed remote builds in B62484: Diff 151107.Feb 17 2025, 8:24 AM
wulf marked 2 inline comments as done.Feb 17 2025, 8:29 AM
In D48983#1117257, @mav wrote:

I have no objections, but I wonder whether maximum of 3 vs 7 might be model-specific?

Linux driver defaults it to 3 and I was not able to find any quirks changing that. May be I just missed something.

sys/dev/acpi_support/acpi_asus_wmi.c
413

UINT32 is ACPI style and uint32_t is FreeBSD. This function converts backlight value from FreeBSD to ACPI

wulf added inline comments.Feb 17 2025, 8:30 AM
share/man/man4/acpi_asus_wmi.4
76

Fixed

sys/dev/acpi_support/acpi_asus_wmi.c
419–421

Fixed

mav accepted this revision.Tue, Feb 18, 6:11 PM
This revision is now accepted and ready to land.Tue, Feb 18, 6:11 PM
Closed by commit rGf134662a1a57: acpi_asus_wmi(4): Improve keyboard backlight support. (authored by wulf). · Explain WhyMon, Mar 17, 3:47 PM
This revision was automatically updated to reflect the committed changes.
wulf added a commit: rGf134662a1a57: acpi_asus_wmi(4): Improve keyboard backlight support..

Revision Contents
Changeset List

PathSize
share/
man/
man4/
10 lines
sys/
dev/
acpi_support/
136 lines
modules/
acpi/
acpi_asus_wmi/
2 lines

Diff 152343

View Options

share/man/man4/acpi_asus_wmi.4

Loading...
View Options

sys/dev/acpi_support/acpi_asus_wmi.c

Loading...
View Options

sys/modules/acpi/acpi_asus_wmi/Makefile

Loading...