Page MenuHomeFreeBSD
Differential D48980

net80211: use IEEE80211_KEY_UNDEFINED() insetad of checking they keyix
AbandonedPublic
Actions

Authored by bz on Feb 13 2025, 1:45 AM.
Tags
None
Referenced Files
F112547926: D48980.diff
Wed, Mar 19, 4:56 PM
Unknown Object (File)
Tue, Mar 11, 12:57 PM
Unknown Object (File)
Wed, Mar 5, 11:06 PM
Unknown Object (File)
Wed, Mar 5, 1:32 PM
Unknown Object (File)
Tue, Mar 4, 11:40 PM
Unknown Object (File)
Mon, Mar 3, 7:58 PM
Unknown Object (File)
Mon, Mar 3, 2:46 PM
Unknown Object (File)
Mon, Feb 24, 10:43 AM
View All 13 Files
Subscribers
adrian
glebius
imp
melifaro
takahiro.kurosawa_gmail.com

Details

Reviewers
adrian
Group Reviewers
wireless
Commits
rG6ddcff36f154: net80211: use IEEE80211_KEY_UNDEFINED() insetad of checking they keyix
rG9763fec11b83: net80211: use IEEE80211_KEY_UNDEFINED() insetad of checking they keyix
Summary

For ieee80211_node_delucastkey() rather than checking the keyix to be
IEEE80211_KEYIX_NONE use the IEEE80211_KEY_UNDEFINED() macro (which
chekes the wk_cipher to be 'none').

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 62413
Build 59297: arc lint + arc unit

Event Timeline

bz created this revision.Feb 13 2025, 1:45 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptFeb 13 2025, 1:45 AM
bz requested review of this revision.Feb 13 2025, 1:45 AM
Harbormaster completed remote builds in B62413: Diff 150940.Feb 13 2025, 1:45 AM
bz added a comment.Feb 13 2025, 1:47 AM

The follow-up logic seems to be an ath(4)-only case so it might be worth double-checking that there is no undocumented condition that made the key check here being done as it was. If you accept this review please state that it seems fine in comment as well.

adrian accepted this revision.Feb 13 2025, 2:14 AM
adrian added a subscriber: adrian.

it doesn't surprise me if ti's ath(4) only as well, that and wi is where this all started.

We should go document some actual correct usage of this so we know what / when to expect stuff.

This revision is now accepted and ready to land.Feb 13 2025, 2:14 AM
Closed by commit rG9763fec11b83: net80211: use IEEE80211_KEY_UNDEFINED() insetad of checking they keyix (authored by bz). · Explain WhyFeb 15 2025, 3:52 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG9763fec11b83: net80211: use IEEE80211_KEY_UNDEFINED() insetad of checking they keyix.
bz added a commit: rG6ddcff36f154: net80211: use IEEE80211_KEY_UNDEFINED() insetad of checking they keyix.Mon, Feb 24, 8:28 PM
takahiro.kurosawa_gmail.com added a subscriber: takahiro.kurosawa_gmail.com.Tue, Mar 4, 11:54 PM

It seems that the condition is inversed by this change.
Probably the key need to be deleted if it is set?

bz reopened this revision.Wed, Mar 5, 12:01 AM

Thank you!

bz mentioned this in D49234: net80211: Fix IEEE80211_KEY_UNDEFINED() in ieee80211_node_delucastkey().Wed, Mar 5, 12:06 AM
bz abandoned this revision.Wed, Mar 5, 12:07 AM

See D49234 now.

bz mentioned this in rG27bf5c405bf2: net80211: Fix IEEE80211_KEY_UNDEFINED() in ieee80211_node_delucastkey().Wed, Mar 5, 9:19 PM

Revision Contents
Changeset List

PathSize
sys/
net80211/
2 lines

Diff 150940

View Options

sys/net80211/ieee80211_node.c

Loading...