iichid(4): Read wMaxInputLength bytes over I2C even if we discards data
ClosedPublic
Actions

Authored by wulf on Feb 12 2025, 7:01 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 18, 7:59 PM

	Unknown Object (File)
	Mon, Apr 7, 8:21 AM

	Unknown Object (File)
	Mar 10 2025, 6:13 AM

	Unknown Object (File)
	Mar 7 2025, 6:50 AM

	Unknown Object (File)
	Mar 4 2025, 9:29 PM

	Unknown Object (File)
	Mar 2 2025, 6:35 PM

	Unknown Object (File)
	Feb 21 2025, 4:19 AM

	Unknown Object (File)
	Feb 20 2025, 7:54 PM

View All 11 Files

Subscribers

imp

Details

Reviewers

mav

Commits

rG548d3aa856a9: iichid(4): Read wMaxInputLength bytes over I2C even if we discards data

Summary

For some devices e.g. ITE5570 it is not enough to read HID-over-I2C
input length header of RESET command response to acknowledge interrupt.
Do a full-size read to avoid interrupt storm.

Sponsored by: Future Crew LLC
MFC after: 2 month

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wulf created this revision.Feb 12 2025, 7:01 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 12 2025, 7:01 AM

wulf requested review of this revision.Feb 12 2025, 7:01 AM

Harbormaster completed remote builds in B62385: Diff 150884.Feb 12 2025, 7:01 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2025, 6:28 AM

Closed by commit rG548d3aa856a9: iichid(4): Read wMaxInputLength bytes over I2C even if we discards data (authored by wulf). · Explain Why

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rG548d3aa856a9: iichid(4): Read wMaxInputLength bytes over I2C even if we discards data.

Revision Contents
Changeset List

Path

Size

sys/

dev/

iicbus/

iichid.c

47 lines

Diff 151997

View Options

iichid(4): Read wMaxInputLength bytes over I2C even if we discards dataClosedPublicActions