Page MenuHomeFreeBSD

PR174581: Clarify recv functions can return 0 if no messages are waiting and the peer has closed the connection.
ClosedPublic

Authored by felix.the.red_gmail.com on Feb 12 2025, 4:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 11, 9:28 AM
Unknown Object (File)
Tue, Mar 11, 3:04 AM
Unknown Object (File)
Fri, Mar 7, 7:35 PM
Unknown Object (File)
Thu, Mar 6, 3:45 AM
Unknown Object (File)
Fri, Feb 28, 3:51 PM
Unknown Object (File)
Feb 17 2025, 6:13 AM
Unknown Object (File)
Feb 16 2025, 11:55 AM
Unknown Object (File)
Feb 14 2025, 5:17 PM
Subscribers

Details

Summary

Change the RETURN VALUES section to indicate 0 is a possible return value.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This section looks great! Would you be willing to mark up those return values as defined variables? I'll Cc some guardians of the syscalls.

This revision is now accepted and ready to land.Feb 12 2025, 3:50 PM

May I commit this?

Yes, just be sure to set the author data correctly in git:

git commit --amend --author="Felix Johnson <felix.the.red@gmail.com>"

And with the trailers:

PR:          174581
Reviewed by: jhb, ziaee
Approved by: mhorne (mentor)

And I believe the title needs to be shortened/summarized.

I realize that this has already been committed but I noticed some style issues. We have a rule to never start a sentence with .Fn or .Nm, but use “The ... function” or “The ... command” to ensure the sentence starts with a capitalized word. The suggested edit is the minimum change to ensure that we don't start a sentence with .Fn recvmmsg. Adding “the ... function[s]” both there and in the previous clause is optional but recommended for consistency.

lib/libsys/recv.2
324