Page MenuHomeFreeBSD
Differential D48876

Patch rcorder(8) and rc(8) to clarify scripts without 'PROVIDE' are not run during system startup. PR: 121440
Needs RevisionPublic
Actions

Authored by felix.the.red_gmail.com on Thu, Feb 6, 11:04 PM.
Tags
Referenced Files
F109987993: D48876.diff
Wed, Feb 12, 3:28 AM
Unknown Object (File)
Thu, Feb 6, 11:07 PM
Subscribers
imp

Details

Reviewers
ziaee
Summary

Clarify scripts without PROVIDE are not run during startup.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 62288
Build 59172: arc lint + arc unit

Event Timeline

felix.the.red_gmail.com created this revision.Thu, Feb 6, 11:04 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, Feb 6, 11:04 PM
felix.the.red_gmail.com requested review of this revision.Thu, Feb 6, 11:04 PM
Harbormaster completed remote builds in B62288: Diff 150656.Thu, Feb 6, 11:04 PM
ziaee requested changes to this revision.EditedSun, Feb 9, 10:17 PM

Hi! I appreciate your attention to the manual bugs! For this one, I don't like this.

rcorder(8) is not the appropriate place to document what rc(8) does with rcorder(8)'s keywords, and rc(8) already says:

"should contain rcorder(8) keywords, especially an appropriate "PROVIDE" entry"

If that line is actually broken, we should fix that line instead of bolting on more bloat. When the manual is too bloated, people don't read it.

This revision now requires changes to proceed.Sun, Feb 9, 10:17 PM
ziaee added a project: manpages.Sun, Feb 9, 10:19 PM
felix.the.red_gmail.com added a comment.Tue, Feb 11, 2:50 AM

Is the fix for PR 121440 to close as not a bug?
I'm not sure what to do otherwise, based on your comment.

Revision Contents
Changeset List

PathSize
sbin/
rcorder/
7 lines
share/
man/
man8/
8 lines

Diff 150656

View Options

sbin/rcorder/rcorder.8

Loading...
View Options

share/man/man8/rc.8

Loading...