Page MenuHomeFreeBSD

Make crypt(3) thread-safe by utilizing thread-local storage.
Needs ReviewPublic

Authored by delphij on Wed, Feb 5, 6:14 AM.
Tags
None
Referenced Files
F109457996: D48858.id.diff
Wed, Feb 5, 8:18 AM
F109456475: D48858.id150515.diff
Wed, Feb 5, 7:48 AM
F109455653: D48858.diff
Wed, Feb 5, 7:31 AM
Subscribers
None

Details

Reviewers
emaste
imp
jrtc27
Summary

The crypt(3) interface is a wrapper around crypt_r(3) where a global
static storage is passed as data. Modernize the interface by
passing a thread-local storage instead so it is thread-safe.

Test Plan

kyua test lib/libcrypt

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 62267
Build 59151: arc lint + arc unit

Event Timeline

delphij created this revision.

It's still not thread-safe if you pass the return value to another thread, but perhaps that's outside the scope