cam/cd: The SAW_MEDIA flag duplicates VALID_MEDIA
ClosedPublic
Actions

Authored by imp on Tue, Feb 4, 6:38 PM.

Details

Reviewers

mav
ken

Group Reviewers

cam

Commits

rG80d0d1614cdc: cam/cd: The SAW_MEDIA flag duplicates VALID_MEDIA

Summary

This change mirrors what we do in da. Use only the VALID_MEDIA
flag. SAW_MEDIA was just used in one place. Transition to using
similar technique to what da uses for valid media.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Tue, Feb 4, 6:38 PM

Herald added a reviewer: cam. · View Herald TranscriptTue, Feb 4, 6:38 PM

imp requested review of this revision.Tue, Feb 4, 6:38 PM

imp added a parent revision: D48840: cam/cd: Simplify to remove invalid flag.

imp added a child revision: D48842: cam/da: Minor rework of sf bits for errors.

Harbormaster completed remote builds in B62251: Diff 150490.Tue, Feb 4, 6:38 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Feb 8, 9:43 PM

Closed by commit rG80d0d1614cdc: cam/cd: The SAW_MEDIA flag duplicates VALID_MEDIA (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG80d0d1614cdc: cam/cd: The SAW_MEDIA flag duplicates VALID_MEDIA.

Revision Contents
Changeset List

Path

Size

sys/

cam/

scsi/

scsi_cd.c

7 lines

Diff 150727

View Options

cam/cd: The SAW_MEDIA flag duplicates VALID_MEDIAClosedPublicActions