Cirrus-CI: Check for final "Uptime" message
ClosedPublic
Actions

Authored by emaste on Mon, Feb 3, 8:21 PM.

Details

Reviewers

kevans
imp

Commits

rG6180d0382df2: Cirrus-CI: Check for final "Uptime" message

Summary

The last thing printed by the kernel after shutdown is Uptime: <time>.
Check also for this to ensure that shutdown is successful.  A test
branch of mine panicked during shutdown, but still reported success in
Cirrus-CI.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Mon, Feb 3, 8:21 PM

emaste created this revision.

emaste added reviewers: kevans, imp.Mon, Feb 3, 8:36 PM

emaste mentioned this in D45409: vm_phys: reduce touching of page->pool fields.Mon, Feb 3, 9:03 PM

kevans added inline comments.Mon, Feb 3, 9:03 PM

tools/boot/ci-qemu-test.sh
127–128	I could maybe see an argument that this could use a better diagnostic message since the boot succeeded, but I don't have a strong opinion

Change successful message

Cirrus-CI run on main with this change: https://cirrus-ci.com/task/6724732722085888

In my WIP tree I seem to have a hang on shutdown, which is caught:

start_init: trying /sbin/init
Hello world.
vm.stats.vm.v_wire_count: 6680
Shutdown NOW!
shutdown: [pid 19]
2025-02-04T03:39:48.159256+00:00 - shutdown 19 - - power-down by root: 
FreeBSD/amd64 (Amnesiac) (ttyu0)
login: qemu-system-x86_64: terminating on signal 15 from pid 18795 (timeout)
Did not boot successfully, see /tmp/ci-qemu-test-boot.log