mk: Move vm stack test debug symbols

[jlduran]

Summary

Avoid the creation of a /usr/tests/sys/vm/stack/.debug directory by
placing sys/vm/stack test debug symbols under /usr/lib/debug.

Test Plan

Let someone who actually understands our make system, fix this issue.

[emaste]

bsd.prog.mk has:

# Use ${DEBUGDIR} for base system debug files, else .debug subdirectory
.if defined(BINDIR) && (\
    ${BINDIR} == "/bin" ||\
    ${BINDIR:C%/libexec(/.*)?%/libexec%} == "/libexec" ||\
    ${BINDIR} == "/sbin" ||\
    ${BINDIR:C%/usr/(bin|bsdinstall|libexec|lpr|sendmail|sm.bin|sbin|tests)(/.*)?%/usr/bin%} == "/usr/bin" ||\
    ${BINDIR} == "/usr/lib" \
     )
DEBUGFILEDIR=   ${DEBUGDIR}${BINDIR}
.else
DEBUGFILEDIR?=  ${BINDIR}/.debug
.endif

presumably the affected test here is the first case that installs a test .so other than under /usr/tests/lib/....

If we assume any .so under /usr/tests is a base system component I'd suggest just removing (tests/)? from the existing expression and adding ${SHLIBDIR:C%/usr/tests(/.*)?%/usr/tests%} == "/usr/tests"

[jlduran]

In D48796#1113489, @emaste wrote:

bsd.prog.mk has:

# Use ${DEBUGDIR} for base system debug files, else .debug subdirectory
.if defined(BINDIR) && (\
    ${BINDIR} == "/bin" ||\
    ${BINDIR:C%/libexec(/.*)?%/libexec%} == "/libexec" ||\
    ${BINDIR} == "/sbin" ||\
    ${BINDIR:C%/usr/(bin|bsdinstall|libexec|lpr|sendmail|sm.bin|sbin|tests)(/.*)?%/usr/bin%} == "/usr/bin" ||\
    ${BINDIR} == "/usr/lib" \
     )
DEBUGFILEDIR=   ${DEBUGDIR}${BINDIR}
.else
DEBUGFILEDIR?=  ${BINDIR}/.debug
.endif

presumably the affected test here is the first case that installs a test .so other than under /usr/tests/lib/....

Yes, so far it is the only one. libsoxstack.so required by tests/sys/vm/stack/stack_dlopen_exec_test.c

If we assume any .so under /usr/tests is a base system component I'd suggest just removing (tests/)? from the existing expression and adding ${SHLIBDIR:C%/usr/tests(/.*)?%/usr/tests%} == "/usr/tests"

That works as well... Will do. Thank you!

[jlduran]

Address suggestions.

[emaste]

etc/mtree/BSD.debug.dist

60–65 ↗

(On Diff #150448)

Is this required? None of the other tests paths are explicitly specified, but are created as expected, afaict?

[jlduran]

Remove wrong mtree entries:

• Test entries are populated from BSD.tests.dist

[jlduran]

Landed as 88d448ec815c1fda27be94846f88ccd96251febd.
Thank you!

[jlduran]

Plus the fix:
955f974a1a37cf3ae8b241327b1fef74c8932855