Page MenuHomeFreeBSD

nanobsd: Add uname/gname to the spec
AcceptedPublic

Authored by jlduran on Feb 1 2025, 4:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 10:55 PM
Unknown Object (File)
Sat, Apr 19, 10:37 PM
Unknown Object (File)
Sat, Apr 19, 9:39 PM
Unknown Object (File)
Sat, Apr 19, 9:38 PM
Unknown Object (File)
Sat, Apr 19, 9:16 PM
Unknown Object (File)
Sat, Apr 19, 9:16 PM
Unknown Object (File)
Sat, Apr 19, 8:40 PM
Unknown Object (File)
Mar 4 2025, 7:03 AM
Subscribers
None

Details

Reviewers
emaste
imp
Summary

Also include the default NanoBSD uname/gname in the specification file.

By default, NANO_DEF_UNAME and NANO_DEF_GNAME map to root and wheel
respectively.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jlduran created this revision.
This revision is now accepted and ready to land.Feb 1 2025, 4:44 AM

I'm not a fan of the wrapping for things like this; IMO it's better to just let it exceed 80 cols, or build up a string to add to the metalog piece by piece, etc.

Address suggestions:

  • Do not wrap strings
This revision now requires review to proceed.Feb 1 2025, 5:28 PM

I'm agnostic on the wrapping... I tend to use a 120ish limit myself, though I know that drives people nuts. Others in the project regularly commit > 80 < 100 lines and have for ~decades. kib is the only one that's still objecting.

This revision is now accepted and ready to land.Feb 1 2025, 5:29 PM