Page MenuHomeFreeBSD

csu tests: Remove extra slash
ClosedPublic

Authored by jlduran on Sat, Feb 1, 4:21 AM.
Tags
None
Referenced Files
F109574471: D48778.id150321.diff
Thu, Feb 6, 10:10 PM
Unknown Object (File)
Thu, Feb 6, 4:32 PM
Unknown Object (File)
Thu, Feb 6, 2:19 PM
Unknown Object (File)
Thu, Feb 6, 11:38 AM
Unknown Object (File)
Tue, Feb 4, 2:56 PM
Unknown Object (File)
Tue, Feb 4, 2:20 PM
Subscribers

Details

Summary

Remove an extra slash that ends up in the metalog. This double slash
can produce an invalid specification file if there are subdirectories
down the hierarchy when sorted.

For example, consider the following metalog excerpt:

./base/aaa type=dir
./base//aaa/bbb type=dir

If sorted, would turn out:

./base//aaa/bbb type=dir
./base/aaa type=dir

Apparently missing the ./base/aaa directory in the specification.

Luckily here are no subdirectories.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sat, Feb 1, 4:40 AM

We could add a check for double slash to tools/pkgbase/metalog_reader.lua also

We could add a check for double slash to tools/pkgbase/metalog_reader.lua also

Yes! I forgot you mentioned it in another review. I'll take a look. Thank you.

This revision was automatically updated to reflect the committed changes.