Differential D48733

unifdef: Fix collision check when adding symbols.
ClosedPublic
Actions

Authored by des on Thu, Jan 30, 6:44 PM.

Details

Reviewers

kevans

Group Reviewers

Klara

Commits

rGc63af363c245: unifdef: Fix collision check when adding symbols.

Summary

findsym() is intended for use while parsing input, so it should not be
called from addsym2() or indirectsym(), which are called before any
input is processed.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62164
Build 59048: arc lint + arc unit

Event Timeline

des created this revision.Thu, Jan 30, 6:44 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Jan 30, 6:44 PM

des requested review of this revision.Thu, Jan 30, 6:44 PM

Harbormaster completed remote builds in B62163: Diff 150222.Thu, Jan 30, 6:44 PM

test name

Harbormaster completed remote builds in B62164: Diff 150223.Thu, Jan 30, 6:46 PM

kevans accepted this revision.Thu, Jan 30, 9:07 PM

This revision is now accepted and ready to land.Thu, Jan 30, 9:07 PM

Closed by commit rGc63af363c245: unifdef: Fix collision check when adding symbols. (authored by des). · Explain WhyThu, Jan 30, 9:11 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGc63af363c245: unifdef: Fix collision check when adding symbols..

Revision Contents
Changeset List

Path

Size

contrib/

unifdef/

unifdef.c

11 lines

usr.bin/

unifdef/

tests/

unifdef_test.sh

10 lines

Diff 150223

View Options

contrib/unifdef/unifdef.c