Paths

Table of Contentst

Differential D48715

arm64: Hook up efi_rt_arch_call in efirt.ko
ClosedPublic
Actions

Authored by jhb on Wed, Jan 29, 4:17 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Feb 5, 2:57 PM

	Unknown Object (File)
	Mon, Feb 3, 11:21 PM

	Unknown Object (File)
	Sun, Feb 2, 12:13 AM

Subscribers

Details

Reviewers

andrew
jrtc27
manu
imp

Commits

rG856d3167995a: arm64: Hook up efi_rt_arch_call in efirt.ko

Summary

Note that this requires marking efi_rt_fault as a non-preemptible
local symbol.

Co-authored-by: Jessica Clarke <jrtc27@FreeBSD.org>
Obtained from: CheriBSD
Fixes: d7f930b80e89 ("arm64: Implement efi_rt_arch_call")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Wed, Jan 29, 4:17 PM

Herald added a reviewer: manu. · View Herald TranscriptWed, Jan 29, 4:17 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

Harbormaster completed remote builds in B62091: Diff 150106.Wed, Jan 29, 4:17 PM

jhb requested review of this revision.Wed, Jan 29, 4:17 PM

imp accepted this revision.Wed, Jan 29, 4:18 PM

This revision is now accepted and ready to land.Wed, Jan 29, 4:18 PM

andrew added inline comments.Wed, Jan 29, 4:27 PM

sys/arm64/arm64/efirt_support.S
99
sys/modules/efirt/Makefile
15	Is this needed? We only build this module on arm64 and amd64.

jhb added inline comments.Wed, Jan 29, 4:46 PM

sys/modules/efirt/Makefile
15	I think there is a desire to have EFI on RISC-V, so leaving this MD might be prudent.

imp added inline comments.Wed, Jan 29, 4:57 PM

sys/modules/efirt/Makefile
15	Maybe just make it unconditional then. Stubs for this one routine are trivial.

Fix LEND

This revision now requires review to proceed.Wed, Jan 29, 4:59 PM

Harbormaster completed remote builds in B62093: Diff 150112.Wed, Jan 29, 4:59 PM

andrew added inline comments.Wed, Jan 29, 5:01 PM

sys/modules/efirt/Makefile
15	I would hope new architectures would implement the fault safe `efi_rt_arch_call` so at some point we could remove `efi_rt_arch_call_nofault` if we decided it was no longer useful.

imp added inline comments.Wed, Jan 29, 5:12 PM

sys/modules/efirt/Makefile
15	Right. We also have to implement PA != VA for these calls for LinuxBoot to work since Linux sers that up and we are stuck with it.

jhb added inline comments.Wed, Jan 29, 8:33 PM

sys/modules/efirt/Makefile
15	CHERI can't yet have a `nofault` variant until we have a CHERI-aware firmware since kernel fault handlers don't work. But I could remove this .if I guess if you feel strongly.

Drop an .if

Harbormaster completed remote builds in B62183: Diff 150299.Fri, Jan 31, 8:38 PM

andrew accepted this revision.Mon, Feb 3, 2:01 PM

This revision is now accepted and ready to land.Mon, Feb 3, 2:01 PM

Closed by commit rG856d3167995a: arm64: Hook up efi_rt_arch_call in efirt.ko (authored by jhb). · Explain WhyWed, Feb 5, 2:51 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG856d3167995a: arm64: Hook up efi_rt_arch_call in efirt.ko.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

efirt_support.S

4 lines

modules/

efirt/

7 lines

Diff 150532

sys/arm64/arm64/efirt_support.S

Loading...

sys/modules/efirt/Makefile

Loading...