tcp: remove check for condition that never happens
ClosedPublic
Actions

Authored by glebius on Tue, Jan 28, 11:26 PM.

Details

Reviewers

markj
cc

Group Reviewers

network
transport

Commits

rG2d99af941040: tcp: remove check for condition that never happens

Summary

A tcpcb in TCPS_LISTEN has always socket in SO_ACCEPTCONN. One block
above there is an assertion that proves that this never happens. We
stopped ever clearing SO_ACCEPTCONN back in 779f106aa169.

This reverts commit 982c1675ff8864f51007e0be402ead88429222bb.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62087
Build 58971: arc lint + arc unit

Event Timeline

glebius created this revision.Tue, Jan 28, 11:26 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptTue, Jan 28, 11:26 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Tue, Jan 28, 11:26 PM

glebius added a parent revision: D48709: sockets: refactor solisten() and pr_listen.

Harbormaster completed remote builds in B62087: Diff 150085.Tue, Jan 28, 11:26 PM

markj accepted this revision as: markj.Wed, Jan 29, 3:00 PM

cc accepted this revision.Fri, Jan 31, 3:10 PM

cc added a subscriber: cc.

cc added inline comments.

sys/netinet/tcp_input.c
1357	Right, this condition should not be valid any more.

This revision is now accepted and ready to land.Fri, Jan 31, 3:10 PM

Closed by commit rG2d99af941040: tcp: remove check for condition that never happens (authored by glebius). · Explain WhyFri, Jan 31, 10:25 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG2d99af941040: tcp: remove check for condition that never happens.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_input.c

9 lines

Diff 150085

View Options

tcp: remove check for condition that never happensClosedPublicActions