preliminary usb support for fwget

[jsm]

Summary

Mostly a copy of pci subsystem support, by replacing pciconf with usbconfig and excluding hardware classes.

Test Plan

fwget usb (with a matched device attached)

[jsm]

sed correct use of quantifier and use * instead of +

[bz]

I was pondering this for a while -- also for other devices -- but I highly felt that usbconfig wanted some improvements first to make this a lot easier.
There are tricky bits with USB devices changing "identity" depending on quirks or other state (i.e., first show up as CD-ROM and then become a network device).

But I am all for a good start :) I'll go and look through to see if I can add a few other bits using your logic next week, if that's ok?

usr.sbin/fwget/usb/usb

60

looks like an indent problem here in Phabricator?

usr.sbin/fwget/usb/usb_ralink

6

I do not think there's anything from the Foundation or me in this file.

[jsm]

Perfectly fine

In D48678#1110205, @bz wrote:

I was pondering this for a while -- also for other devices -- but I highly felt that usbconfig wanted some improvements first to make this a lot easier.
There are tricky bits with USB devices changing "identity" depending on quirks or other state (i.e., first show up as CD-ROM and then become a network device).

But I am all for a good start :) I'll go and look through to see if I can add a few other bits using your logic next week, if that's ok?

Perfectly fine with me.

[jbeich]

I'm not familar with fwget code and don't use WiFi, so can't review.

[bz]

In D48678#1110205, @bz wrote:

But I am all for a good start :) I'll go and look through to see if I can add a few other bits using your logic next week, if that's ok?

Perfectly fine with me.

Not made it and likely will not the next 3-4 days. If this needs to go in, please let me know and I'll review the current version and then defer any further changes to the future.

[ziaee]

Manu wrote fwget so, adding him.

[ziaee]

I think for fwget.8 you can just `%s/default pci/valid types are:
.Dv pci ,
.Dv usb ./"

(But I don't actually know the syntax for using newlines in a replace)

[manu]

I'm fine with this but maybe we should expand the manpage to list subsystems

[jsm]

Just some nits, see also https://reviews.freebsd.org/D48944

[jsm]

changes after https://reviews.freebsd.org/D48974

[bz]

I'll try to get D48974 in.
If you fix the man page, empty line and remove the "portions of this..." from usb_ralink I hope we'll be good to go.

usr.sbin/fwget/fwget.8

26

Please don't forget to update .Dd before comitting

usr.sbin/fwget/usb/usb

41

unneeded empty line

[ziaee]

I see no change in fwget output when testing using git-arc.sh patch -C D48678; cd usr.sbin/fwget; make install; fwget on todays's CURRENT .

I have an Intel AX211, I do not know if it needs the firmware from comms/iwmbt-firmware, but when I install it manually my dmesg does change.

[bz]

In D48678#1122262, @ziaee wrote:

I see no change in fwget output when testing using git-arc.sh patch -C D48678; cd usr.sbin/fwget; make install; fwget on todays's CURRENT .

I have an Intel AX211, I do not know if it needs the firmware from comms/iwmbt-firmware, but when I install it manually my dmesg does change.

This doesn't add any BT devices; I have a TODO to do so when this landed.

[ziaee]

While we've been waiting, I came up with some additional suggestions for your consideration.

usr.sbin/fwget/fwget.8

26

I'm sorry for making this kind of super annoying nit, but makewhatis will complain every time the manual database is manually compiled.

50–53

Sorry to back track on this, but (while we're waiting) I think I've got something better.

In this case, pci or usb are really command modifiers in my mind, and this also makes them render bold.

Additionally, I am hoping this shows that can use one, or both separated by a space.

69

Linking to the driver overview pages here would be very nice, and subsystems should be plural here.