sound tests: Fix 32bit calculation detection in pcm_read_write
ClosedPublic
Actions

Authored by dev_submerge.ch on Thu, Jan 23, 3:43 AM.

Details

Reviewers

christos
markj
emaste

Commits

rGe02b579b5379: sound tests: Fix 32bit calculation detection in pcm_read_write

Summary

Fix a mistake in the pcm_read_write test that would result in not
properly detecting 32bit calculation on 32bit architectures like i386.
As a consequence, the wrong values would be checked, thus failing the
test.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dev_submerge.ch created this revision.Thu, Jan 23, 3:43 AM

Herald added a subscriber: imp. · View Herald TranscriptThu, Jan 23, 3:43 AM

dev_submerge.ch requested review of this revision.Thu, Jan 23, 3:43 AM

Harbormaster completed remote builds in B61911: Diff 149749.Thu, Jan 23, 3:43 AM

To the best of my knowledge, this should fix the test on i386. I haven't spotted any other test failures yet on CI, but that's not conclusive - some architectures seem to have build failures and won't run the tests.

LGTM. I just saw that https://ci.freebsd.org/job/FreeBSD-main-i386-test/lastUnstableBuild/testReport/junit/sys.sound/pcm_read_write/pcm_read/ reported this error, as a result of the 32 -> 24 bit conversion not happening.

EDIT: Seems like you linked to this as well yesterday. :-)

This revision is now accepted and ready to land.Thu, Jan 23, 12:30 PM

Closed by commit rGe02b579b5379: sound tests: Fix 32bit calculation detection in pcm_read_write (authored by dev_submerge.ch, committed by christos). · Explain WhyThu, Jan 23, 12:40 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGe02b579b5379: sound tests: Fix 32bit calculation detection in pcm_read_write.