Differential D48569

rpc: limited multithread support for svc_nl
ClosedPublic
Actions

Authored by glebius on Mon, Jan 20, 9:13 PM.

Tags

None

Referenced Files

	F109271514: D48569.diff
	Sun, Feb 2, 9:07 PM

	F109254018: D48569.diff
	Sun, Feb 2, 4:11 PM

	Unknown Object (File)
	Sat, Feb 1, 7:14 PM

	Unknown Object (File)
	Sat, Feb 1, 3:58 PM

	Unknown Object (File)
	Sat, Feb 1, 3:56 PM

	Unknown Object (File)
	Fri, Jan 31, 8:10 AM

	Unknown Object (File)
	Thu, Jan 30, 1:29 AM

	Unknown Object (File)
	Mon, Jan 27, 10:11 PM

View All 17 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGc62ae124cc78: rpc: limited multithread support for svc_nl

Summary

The rpc(3) itself was not designed with multithreading in mind, but we can
actually achieve some parallelism without modifying the library and the
framework. This transport will allow to process RPCs in threads, with
some hacks on the application side (documented in code). We make
reentrable only one method - SVC_REPLY(). Reading and parsing of incoming
calls is still done synchronously. But the actual processing of the calls
can be offloaded to a thread, and once finished the thread can safely
execute SVC_REPLY() and the reply would be sent with the correct xid.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61842
Build 58726: arc lint + arc unit

Event Timeline

glebius created this revision.Mon, Jan 20, 9:13 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jan 20, 9:13 PM

glebius requested review of this revision.Mon, Jan 20, 9:13 PM

glebius added a parent revision: D48568: netlink: provide snl_clone() to create a secondary snl state.

Harbormaster completed remote builds in B61842: Diff 149616.Mon, Jan 20, 9:13 PM

glebius added a child revision: D48570: rpc.tlsservd: provide parallelism with help of pthread(3).Mon, Jan 20, 9:14 PM

Update with respect to committed changes and snl(3) as well as unstacked
changes to snl(3).

Harbormaster completed remote builds in B61846: Diff 149621.Mon, Jan 20, 9:46 PM

Looks ok to me but I do not know pthreads.

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Feb 1, 9:04 AM

Closed by commit rGc62ae124cc78: rpc: limited multithread support for svc_nl (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGc62ae124cc78: rpc: limited multithread support for svc_nl.

Revision Contents
Changeset List

Path

Size

include/

rpc/

7 lines

lib/

libc/

rpc/

106 lines

Diff 149616

include/rpc/svc.h

Loading...

lib/libc/rpc/svc_nl.c

Loading...