Page MenuHomeFreeBSD
Differential D48502

depend-cleanup: bea89d038ac5 also moved memchr
ClosedPublic
Actions

Authored by emaste on Fri, Jan 17, 3:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 20, 1:52 PM
Unknown Object (File)
Mon, Jan 20, 12:05 PM
Unknown Object (File)
Mon, Jan 20, 11:54 AM
Unknown Object (File)
Mon, Jan 20, 11:17 AM
Unknown Object (File)
Fri, Jan 17, 3:19 PM
Subscribers
imp
jrtc27

Details

Reviewers
andrew
fuz
getz
Commits
rGd355c28a0954: depend-cleanup: bea89d038ac5 also moved memchr
Summary
Commit bea89d038ac5 added strlcat but also introduced a memchr wrapper
in the source tree rather than using the autogenerated one used for
AARCH64_STRING_FUNCS.  Move memchr.S to MDSRS and add a cleanup rule for
the old wrapper.

Fixes: bea89d038ac5 ("lib/libc/aarch64/string: add strlcat SIMD implementation")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Fri, Jan 17, 3:11 PM
Herald added a reviewer: andrew. · View Herald TranscriptFri, Jan 17, 3:11 PM
Herald added a subscriber: jrtc27. · View Herald Transcript
emaste requested review of this revision.Fri, Jan 17, 3:11 PM
emaste added reviewers: fuz, getz.
emaste added inline comments.
lib/libc/aarch64/string/Makefile.inc
21

We're still using Arm's memchr, but have a wrapper in the src tree rather than using the generated one below.

jrtc27 added a comment.Fri, Jan 17, 3:15 PM

Uh, why do we need that wrapper instead of just calling memchr itself?

fuz accepted this revision.Fri, Jan 17, 3:15 PM

Sorry for missing this one too. All these build system hacks are confusing.

This revision is now accepted and ready to land.Fri, Jan 17, 3:15 PM
Closed by commit rGd355c28a0954: depend-cleanup: bea89d038ac5 also moved memchr (authored by emaste). · Explain WhyFri, Jan 17, 3:19 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGd355c28a0954: depend-cleanup: bea89d038ac5 also moved memchr.
Herald added a subscriber: imp. · View Herald TranscriptFri, Jan 17, 3:19 PM
emaste added a comment.Fri, Jan 17, 3:24 PM

Uh, why do we need that wrapper instead of just calling memchr itself?

The wrapper is just including arm-optimized-routines memchr.S as the autogenerated one does, and the net effect is to switch from #define __memchr_aarch64 memchr to .set memchr __memchr_aarch64. I guess we need a more holistic cleanup of this.

Revision Contents
Changeset List

PathSize
lib/
libc/
aarch64/
string/
2 lines
tools/
build/
3 lines

Diff 149458

View Options

lib/libc/aarch64/string/Makefile.inc

Loading...
View Options

tools/build/depend-cleanup.sh

Loading...