Differential D48499

ktrace: Fix uninitialized memory disclosure
ClosedPublic
Actions

Authored by markj on Fri, Jan 17, 2:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 21, 10:47 AM

	Unknown Object (File)
	Mon, Jan 20, 1:55 PM

Subscribers

Details

Reviewers

jfree
emaste

Commits

rG99d5ee8738a3: ktrace: Fix uninitialized memory disclosure
rG5b86888bae65: ktrace: Fix uninitialized memory disclosure

Summary

The sockaddr passed to ktrcapfail() may be smaller than
sizeof(struct sockaddr), and the trailing bytes in the sockaddr
structure will be uninitialized, whereupon they get copied out to
userspace.

PR: 283673
Reported by: Yichen Chai <yichen.chai@gmail.com>
Reported by: Zhuo Ying Jiang Li <zyj20@cl.cam.ac.uk>
Fixes: 9bec84131215 ("ktrace: Record detailed ECAPMODE violations")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Fri, Jan 17, 2:21 PM

Herald added subscribers: olce, imp. · View Herald TranscriptFri, Jan 17, 2:21 PM

markj requested review of this revision.Fri, Jan 17, 2:21 PM

Harbormaster completed remote builds in B61783: Diff 149452.Fri, Jan 17, 2:22 PM

emaste accepted this revision.Fri, Jan 17, 2:41 PM

This revision is now accepted and ready to land.Fri, Jan 17, 2:41 PM

jfree accepted this revision.Sun, Jan 19, 10:08 PM

Closed by commit rG5b86888bae65: ktrace: Fix uninitialized memory disclosure (authored by markj). · Explain WhyMon, Jan 20, 1:55 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG5b86888bae65: ktrace: Fix uninitialized memory disclosure.

markj added a commit: rG99d5ee8738a3: ktrace: Fix uninitialized memory disclosure.Mon, Jan 20, 10:10 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

11 lines

Diff 149538

sys/kern/kern_ktrace.c

Loading...