bnxt_en: Remove pointless NULL check for sysctl arg1
ClosedPublic
Actions

Authored by zlei on Jan 17 2025, 11:14 AM.

Details

Reviewers

chandrakanth.patil_broadcom.com
sumit.saxena_broadcom.com
imp
shurd
markj

Commits

rG072303d432eb: bnxt_en: Remove pointless NULL check for sysctl arg1
rG747fd2db538a: bnxt_en: Remove pointless NULL check for sysctl arg1

Summary

Those sysctl handlers have been guaranteed to have non-null softc. No need for NULL check within sysctl handlers.

No functional change intended.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

I do not have this hardware, better have this change tested before landing.

zlei added a child revision: D48496: bnxt_en: Improve sysctl handler bnxt_dcb_list_app().Jan 17 2025, 11:25 AM

zlei added a reviewer: markj.Jan 18 2025, 2:41 PM

markj accepted this revision.Jan 18 2025, 3:04 PM

markj added inline comments.

sys/dev/bnxt/bnxt_en/bnxt_sysctl.c
2110	This assertion is not very useful since the dereference below will crash if the softc is null.

This revision is now accepted and ready to land.Jan 18 2025, 3:04 PM

zlei added inline comments.Jan 18 2025, 3:30 PM

sys/dev/bnxt/bnxt_en/bnxt_sysctl.c
2110	Indeed true. I thought a `MPASS` will make the review easier :) I can restore it while landing.

Closed by commit rG747fd2db538a: bnxt_en: Remove pointless NULL check for sysctl arg1 (authored by zlei). · Explain WhyFeb 14 2025, 10:42 AM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG747fd2db538a: bnxt_en: Remove pointless NULL check for sysctl arg1.

zlei added a commit: rG072303d432eb: bnxt_en: Remove pointless NULL check for sysctl arg1.Sat, Feb 22, 2:52 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

bnxt/

bnxt_en/

bnxt_sysctl.c

18 lines

Diff 151014

View Options

sys/dev/bnxt/bnxt_en/bnxt_sysctl.c

bnxt_en: Remove pointless NULL check for sysctl arg1ClosedPublicActions