bintrans: disable argument permutation for qp and base64
AcceptedPublic
Actions

Authored by kevans on Thu, Jan 16, 2:47 PM.

Details

Reviewers

pstef
bapt
emaste

Summary

Err on the side of caution and revert to the BSD-style getopt(3)
behavior for argument processing, as it's harder to go back and it's
not clear that this was strictly intentional.

This is the difference between base64 /COPYRIGHT -w 80 and
base64 -w 80 /COPYRIGHT.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61763
Build 58647: arc lint + arc unit

Event Timeline

kevans created this revision.Thu, Jan 16, 2:47 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Jan 16, 2:47 PM

kevans requested review of this revision.Thu, Jan 16, 2:47 PM

Harbormaster completed remote builds in B61763: Diff 149341.Thu, Jan 16, 2:47 PM

bapt accepted this revision.Thu, Jan 16, 2:50 PM

This revision is now accepted and ready to land.Thu, Jan 16, 2:50 PM

This looks reasonable to me but could it be that whatever base64 exists on typical Linux distros allows "incorrect" argument order?

In D48483#1106209, @emaste wrote:

This looks reasonable to me but could it be that whatever base64 exists on typical Linux distros allows "incorrect" argument order?

Hmm... I was basing it off of the port (which doesn't), but the coreutils base64 is indeed different from that (and there's also a perl script I've seen used in places) and does do the GNU-style permutation.