Differential D48471

fusefs: add more tests for buggy FUSE servers
Needs ReviewPublic
Actions

Authored by asomers on Wed, Jan 15, 8:22 PM.

Tags

None

Referenced Files

	F107751455: D48471.diff
	Fri, Jan 17, 11:23 PM

	F107657233: D48471.id.diff
	Fri, Jan 17, 6:46 AM

	Unknown Object (File)
	Thu, Jan 16, 11:08 AM

	Unknown Object (File)
	Wed, Jan 15, 8:58 PM

Subscribers

Details

Reviewers

Summary

If a FUSE file system is NFS-exported (either by a kernel or userspace NFS server), then it must support FUSE_LOOKUP operations for ".". But if the response reports a different nodeid than the request, that's very bad. Fail the operation and warn the operator.

In general, a FUSE file may have a distinct "nodeid" and "inode number". But it the file system is NFS-exported (either by a kernel or userspace NFS server), then those two must match, because the NFS server will do VFS_VGET operations using the inode number. If they don't match, warn the operator.

MFC after: 2 weeks
Sponsored by: ConnectWise

Test Plan

Test cases added

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 61743
Build 58627: arc lint + arc unit

Event Timeline

asomers created this revision.Wed, Jan 15, 8:22 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Jan 15, 8:22 PM

asomers requested review of this revision.Wed, Jan 15, 8:22 PM

Harbormaster completed remote builds in B61742: Diff 149308.Wed, Jan 15, 8:22 PM

Cleanup trailing whitespace

Harbormaster completed remote builds in B61743: Diff 149309.Wed, Jan 15, 8:24 PM

Revision Contents
Changeset List

Path

Size

sys/

fs/

fuse/

2 lines

19 lines

13 lines

tests/

sys/

fs/

fusefs/

last_local_modify.cc

5 lines

7 lines

106 lines

Diff 149309

sys/fs/fuse/fuse_ipc.h

Loading...

sys/fs/fuse/fuse_node.c

Loading...

sys/fs/fuse/fuse_vfsops.c

Loading...

tests/sys/fs/fusefs/last_local_modify.cc

Loading...

tests/sys/fs/fusefs/lookup.cc

Loading...

tests/sys/fs/fusefs/nfs.cc

Loading...