Page MenuHomeFreeBSD
Differential D48432

editors/emacs: Update to 30.1
ClosedPublic
Actions

Authored by jrm on Jan 11 2025, 9:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 4, 7:04 PM
Unknown Object (File)
Thu, Feb 27, 4:20 AM
Unknown Object (File)
Tue, Feb 25, 12:47 AM
Unknown Object (File)
Mon, Feb 24, 9:55 PM
Unknown Object (File)
Mon, Feb 24, 9:33 PM
Unknown Object (File)
Mon, Feb 24, 8:47 AM
Unknown Object (File)
Wed, Feb 5, 9:50 PM
Unknown Object (File)
Feb 4 2025, 2:10 AM
View All 17 Files
Subscribers
None

Details

Reviewers
yasu
ashish
Commits
R11:f415fceb0609: editors/emacs: Update to 30.1
R11:e0799128b93a: editors/emacs: Update to 30.1
Summary

The updated Canna patches were created by HIROSE yuuji <yuuji@gentei.org>.

Release announcement:   https://lists.gnu.org/archive/html/info-gnu-emacs/2025-02/msg00009.html
Sponsored by:           The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D48432

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrm requested review of this revision.Jan 11 2025, 9:03 PM
jrm created this revision.
Harbormaster completed remote builds in B61676: Diff 149139.Jan 11 2025, 9:04 PM
jrm updated this revision to Diff 149140.Jan 11 2025, 9:06 PM

Remove extra SUB_LIST=...

Harbormaster completed remote builds in B61677: Diff 149140.Jan 11 2025, 9:06 PM
jrm added a comment.Jan 11 2025, 9:12 PM
  1. @yasu, are you able to handle updating the canna patch?
  1. I turned NATIVECOMP on by default. What do you think? I've been running it for years, and it's been stable. Are there still issues compiling some packages? I haven't encountered any, but I also didn't do any research. If there are no known issues, should we remove pkg-message?
jrm mentioned this in D48433: lang/php-mode.el: Update to 1.27.0.Jan 11 2025, 10:23 PM
yasu added a comment.EditedJan 13 2025, 5:19 AM
In D48432#1104894, @jrm wrote:
  1. @yasu, are you able to handle updating the canna patch?

Ok, I'll request it to author after 30.1 is released.

  1. I turned NATIVECOMP on by default. What do you think? I've been running it for years, and it's been stable. Are there still issues compiling some packages? I haven't encountered any, but I also didn't do any research. If there are no known issues, should we remove pkg-message?

Upstream enabled native compilation by default with emacs-30 branch. So we should follow it.
As for pkg-message, I think we should keep it for a while. For most users of editors/emacs 30.1 will be there first experience with native compilation. So they may face issue with it and it may be helpful for them to provide workaround to disable it with user settings. For example, how about keeping pkg-message until it is updated to Emacs 31?

jrm added a comment.Jan 13 2025, 2:10 PM
In D48432#1105087, @yasu wrote:
In D48432#1104894, @jrm wrote:
  1. @yasu, are you able to handle updating the canna patch?

Ok, I'll request it to author after 30.1 is released.

I incorrectly recalled that you had updated the patch in the past. Since it's just a matter of communication, I'll send emails.

  1. I turned NATIVECOMP on by default. What do you think? I've been running it for years, and it's been stable. Are there still issues compiling some packages? I haven't encountered any, but I also didn't do any research. If there are no known issues, should we remove pkg-message?

Upstream enabled native compilation by default with emacs-30 branch. So we should follow it.
As for pkg-message, I think we should keep it for a while. For most users of editors/emacs 30.1 will be there first experience with native compilation. So they may face issue with it and it may be helpful for them to provide workaround to disable it with user settings. For example, how about keeping pkg-message until it is updated to Emacs 31?

Sounds good. Thank you.

jrm updated this revision to Diff 149317.Jan 16 2025, 1:15 AM

Incorporate updated Canna patches from HIROSE yuuji <yuuji@gentei.org>.

Harbormaster completed remote builds in B61748: Diff 149317.Jan 16 2025, 1:15 AM
jrm updated this revision to Diff 151292.Fri, Feb 21, 3:38 AM

Update for RC1

Harbormaster completed remote builds in B62559: Diff 151292.Fri, Feb 21, 3:38 AM
jrm updated this revision to Diff 151293.Fri, Feb 21, 3:54 AM

Mk/Uses: Update EMACS_VER to 30.1

Harbormaster completed remote builds in B62560: Diff 151293.Fri, Feb 21, 3:54 AM
jrm retitled this revision from editors/emacs: WIP to prepare for imminent 30.1 release to editors/emacs: Update to 30.1.Mon, Feb 24, 1:42 AM
jrm updated this revision to Diff 151384.Mon, Feb 24, 1:45 AM

Emacs 30.1 is released. I will put the PORTREVISION bumps in a separate review. Minor changes will be required when HIROSE yuuji updates the canna patch.

Harbormaster completed remote builds in B62602: Diff 151384.Mon, Feb 24, 1:45 AM
jrm edited the summary of this revision. (Show Details)Mon, Feb 24, 5:20 AM
jrm updated this revision to Diff 151419.Mon, Feb 24, 6:05 PM
jrm edited the summary of this revision. (Show Details)

Update Canna patches

Harbormaster completed remote builds in B62617: Diff 151419.Mon, Feb 24, 6:05 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Feb 24, 9:45 PM
Closed by commit R11:e0799128b93a: editors/emacs: Update to 30.1 (authored by jrm). · Explain Why
This revision was automatically updated to reflect the committed changes.
jrm added a commit: R11:e0799128b93a: editors/emacs: Update to 30.1.
jrm added a commit: R11:f415fceb0609: editors/emacs: Update to 30.1.Tue, Feb 25, 2:28 AM

Revision Contents
Changeset List

PathSize
Mk/
Uses/
2 lines
editors/
emacs/
38 lines
10 lines
files/
75 lines
184 lines

Diff 151437

View Options

Mk/Uses/emacs.mk

Loading...
View Options

editors/emacs/Makefile

Loading...
View Options

editors/emacs/distinfo

Loading...
View Options

editors/emacs/files/patch-tty-rgb

Loading...
View Options

editors/emacs/files/pkg-message.in

Loading...
View Options

editors/emacs/pkg-plist

Loading...